fix that js/file-system-race could have FPs related to loops

2026-04-20 06:24:03 +02:00 · 2022-10-11 13:41:51 +02:00
parent 02656b16c3
commit 7500a31814
2 changed files with 6 additions and 1 deletions
--- a/javascript/ql/src/Security/CWE-367/FileSystemRace.ql
+++ b/javascript/ql/src/Security/CWE-367/FileSystemRace.ql
@@ -106,7 +106,7 @@ predicate useAfterCheck(FileCheck check, FileUse use) {
    )
  )
  or
-  check.getBasicBlock().getASuccessor+() = use.getBasicBlock()
+  check.getBasicBlock().(ReachableBasicBlock).strictlyDominates(use.getBasicBlock())
 }

 from FileCheck check, FileUse use