hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-23 18:33:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve style of interpretField

Browse Source
This commit is contained in:
Chris Smowton
2021-06-17 12:45:44 +01:00
parent 5cf0243dd0
commit 74b2a2c7a6
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
java/ql/src/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -70,14 +70,13 @@ predicate summaryElement(DataFlowCallable c, string input, string output, string
)
}
bindingset[name]
private FieldContent interpretField(string name) {
exists(string splitRegex, string package, string className, string fieldName |
splitRegex = "^(.*)\\.([^.]+)\\.([^.]+)$" and
package = name.regexpCapture(splitRegex, 1) and
className = name.regexpCapture(splitRegex, 2) and
fieldName = name.regexpCapture(splitRegex, 3)
|
private FieldContent parseField(string c) {
External::specSplit(_, c, _) and
exists(string fieldRegex, string package, string className, string fieldName |
fieldRegex = "^Field (.*)\\.([^.]+)\\.([^.]+)$" and
package = c.regexpCapture(fieldRegex, 1) and
className = c.regexpCapture(fieldRegex, 2) and
fieldName = c.regexpCapture(fieldRegex, 3) and
result.getField().hasQualifiedName(package, className, fieldName)
)
}
@@ -85,7 +84,7 @@ private FieldContent interpretField(string name) {
/** Gets the summary component for specification component `c`, if any. */
bindingset[c]
SummaryComponent interpretComponentSpecific(string c) {
c.matches("Field %") and result = SummaryComponent::content(interpretField(c.splitAt(" ", 1)))
result = SummaryComponent::content(parseField(c))
or
c = "ArrayElement" and result = SummaryComponent::content(any(ArrayContent c0))
or