hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Apply code style suggestion.

Browse Source
This commit is contained in:
Geoffrey White
2022-04-26 16:53:24 +01:00
parent 79aba67036
commit 742949154b
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cpp/ql/src/Security/CWE/CWE-611/XXE.ql
View File

@@ -109,9 +109,8 @@ class DisableDefaultEntityResolutionTranformer extends XXEFlowStateTranformer {
}
final override XXEFlowState transform(XXEFlowState flowstate) {
exists(int disabledDefaultEntityResolution, int createEntityReferenceNodes |
encodeXercesDOMFlowState(flowstate, disabledDefaultEntityResolution,
createEntityReferenceNodes) and
exists(int createEntityReferenceNodes |
encodeXercesDOMFlowState(flowstate, _, createEntityReferenceNodes) and
(
newValue.getValue().toInt() = 1 and // true
encodeXercesDOMFlowState(result, 1, createEntityReferenceNodes)
@@ -142,9 +141,8 @@ class CreateEntityReferenceNodesTranformer extends XXEFlowStateTranformer {
}
final override XXEFlowState transform(XXEFlowState flowstate) {
exists(int disabledDefaultEntityResolution, int createEntityReferenceNodes |
encodeXercesDOMFlowState(flowstate, disabledDefaultEntityResolution,
createEntityReferenceNodes) and
exists(int disabledDefaultEntityResolution |
encodeXercesDOMFlowState(flowstate, disabledDefaultEntityResolution, _) and
(
newValue.getValue().toInt() = 1 and // true
encodeXercesDOMFlowState(result, disabledDefaultEntityResolution, 1)
@@ -208,5 +206,4 @@ class XXEConfiguration extends DataFlow::Configuration {
from XXEConfiguration conf, DataFlow::PathNode source, DataFlow::PathNode sink
where conf.hasFlowPath(source, sink)
select sink, source, sink,
"This $@ is not configured to prevent an XML external entity (XXE) attack.", source,
"XML parser"
"This $@ is not configured to prevent an XML external entity (XXE) attack.", source, "XML parser"