hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Fix likely bug in ExposeRepresentation and re-autoformat.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2018-10-11 10:15:25 +02:00
parent 6a8a27201e
commit 73f1beecfd
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
View File

@@ -81,9 +81,11 @@ predicate mayWriteToArray(Expr modified) {
predicate writesToArray(Expr array) {
relevantType(array.getType()) and
(exists(Assignment a, ArrayAccess access | a.getDest() = access | access.getArray() = array))
or
exists(MethodAccess ma | ma.getQualifier() = array | modifyMethod(ma.getMethod()))
(
exists(Assignment a, ArrayAccess access | a.getDest() = access | access.getArray() = array)
or
exists(MethodAccess ma | ma.getQualifier() = array | modifyMethod(ma.getMethod()))
)
}
VarAccess modificationAfter(VarAccess v) {