From 730d5425b3ae3c37428598bc57529f77279c3063 Mon Sep 17 00:00:00 2001 From: Cornelius Riemenschneider Date: Tue, 21 May 2024 17:30:27 +0200 Subject: [PATCH] C#: Add comment justifing turning off strict deps. --- .bazelrc.internal | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.bazelrc.internal b/.bazelrc.internal index befc427cc3c..f7718959c9d 100644 --- a/.bazelrc.internal +++ b/.bazelrc.internal @@ -3,4 +3,8 @@ common --registry=file:///%workspace%/ql/misc/bazel/registry common --registry=https://bcr.bazel.build +# See bazelbuild/rules_dotnet#413: strict_deps in C# also appliy to 3rd-party deps, and when we pull +# in (for example) the xunit package, there's no code in this at all, it just depends transitively on +# its implementation packages without providing any code itself. +# We either can depend on internal implementation details, or turn of strict deps. common --@rules_dotnet//dotnet/settings:strict_deps=false