hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename class to CredentialsSinkNode to better align with naming convention

Browse Source 
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com>
This commit is contained in:
Edward Minnix III
2023-09-03 21:56:15 -04:00
committed by Ed Minnix
parent c6641dfbf3
commit 72a1289eba
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/lib/change-notes/2023-08-23-deprecated-sensitiveapi-predicates.md
View File

@@ -1,4 +1,4 @@
---
category: deprecated
---
* In `SensitiveApi.qll`, `javaApiCallablePasswordParam`, `javaApiCallableUsernameParam`, `javaApiCallableCryptoKeyParam`, and `otherApiCallableCredentialParam` predicates have been deprecated. They have been replaced with a new class `CredentialSinkNode` and its child classes `PasswordSink`, `UsernameSink`, and `CryptoKeySink`.
* In `SensitiveApi.qll`, `javaApiCallablePasswordParam`, `javaApiCallableUsernameParam`, `javaApiCallableCryptoKeyParam`, and `otherApiCallableCredentialParam` predicates have been deprecated. They have been replaced with a new class `CredentialsSinkNode` and its child classes `PasswordSink`, `UsernameSink`, and `CryptoKeySink`.

2
java/ql/lib/semmle/code/java/security/HardcodedCredentials.qll
View File

@@ -58,7 +58,7 @@ abstract class CredentialsSink extends Expr {
* credentials.
*/
class CredentialsApiSink extends CredentialsSink {
CredentialsApiSink() { this = any(CredentialSinkNode csn).asExpr() }
CredentialsApiSink() { this = any(CredentialsSinkNode csn).asExpr() }
}
/**

8
java/ql/lib/semmle/code/java/security/SensitiveApi.qll
View File

@@ -9,26 +9,26 @@ private import semmle.code.java.dataflow.ExternalFlow
/**
* A node that represents the use of a credential.
*/
abstract class CredentialSinkNode extends DataFlow::Node { }
abstract class CredentialsSinkNode extends DataFlow::Node { }
/**
* A node representing a password being passed to a method.
*/
class PasswordSink extends CredentialSinkNode {
class PasswordSink extends CredentialsSinkNode {
PasswordSink() { sinkNode(this, "credentials-password") }
}
/**
* A node representing a username being passed to a method.
*/
class UsernameSink extends CredentialSinkNode {
class UsernameSink extends CredentialsSinkNode {
UsernameSink() { sinkNode(this, "credentials-username") }
}
/**
* A node representing a cryptographic key being passed to a method.
*/
class CryptoKeySink extends CredentialSinkNode {
class CryptoKeySink extends CredentialsSinkNode {
CryptoKeySink() { sinkNode(this, "crypto-parameter") }
}