diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll deleted file mode 100644 index 0595cbf7d3f..00000000000 --- a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll +++ /dev/null @@ -1,56 +0,0 @@ -/** - * Provides consistency queries for checking invariants in the language-specific - * data-flow classes and predicates. - */ - -private import python -private import DataFlowImplSpecific -private import TaintTrackingImplSpecific -private import codeql.dataflow.internal.DataFlowImplConsistency - -private module Input implements InputSig { - private import Private - private import Public - - predicate argHasPostUpdateExclude(ArgumentNode n) { - exists(ArgumentPosition apos | n.argumentOf(_, apos) and apos.isStarArgs(_)) - or - exists(ArgumentPosition apos | n.argumentOf(_, apos) and apos.isDictSplat()) - } - - predicate reverseReadExclude(Node n) { - // since `self`/`cls` parameters can be marked as implicit argument to `super()`, - // they will have PostUpdateNodes. We have a read-step from the synthetic `**kwargs` - // parameter, but dataflow-consistency queries should _not_ complain about there not - // being a post-update node for the synthetic `**kwargs` parameter. - n instanceof SynthDictSplatParameterNode - } - - predicate uniqueParameterNodePositionExclude(DataFlowCallable c, ParameterPosition pos, Node p) { - // For normal parameters that can both be passed as positional arguments or keyword - // arguments, we currently have parameter positions for both cases.. - // - // TODO: Figure out how bad breaking this consistency check is - exists(Function func, Parameter param | - c.getScope() = func and - p = parameterNode(param) and - c.getParameter(pos) = p and - param = func.getArg(_) and - param = func.getArgByName(_) - ) - } - - predicate uniqueCallEnclosingCallableExclude(DataFlowCall call) { - not exists(call.getLocation().getFile().getRelativePath()) - } - - predicate identityLocalStepExclude(Node n) { - not exists(n.getLocation().getFile().getRelativePath()) - } - - predicate multipleArgumentCallExclude(ArgumentNode arg, DataFlowCall call) { - isArgumentNode(arg, call, _) - } -} - -module Consistency = MakeConsistency;