hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Minor fixes from code review

Browse Source 
Co-authored-by: Taus <tausbn@gmail.com>
This commit is contained in:
Rasmus Wriedt Larsen
2020-06-10 16:14:21 +02:00
committed by GitHub
parent baa415fec8
commit 721713b9e1
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
python/ql/src/Variables/UndefinedExport.ql
View File

@@ -40,7 +40,7 @@ predicate mutates_globals(ModuleValue m) {
(
// In Python < 3.8, Enum._convert can be found with points-to
exists(Value enum_convert |
enum_convert = enum_class.attr(["_convert"]) and
enum_convert = enum_class.attr("_convert") and
exists(CallNode call | call.getScope() = m.getScope() |
enum_convert.getACall() = call or
call.getFunction().pointsTo(enum_convert)
@@ -48,7 +48,7 @@ predicate mutates_globals(ModuleValue m) {
)
or
// In Python 3.8, Enum._convert_ is implemented using a metaclass, and our points-to
// analysis doesn't handle that good enough. So we need special case for this
// analysis doesn't handle that well enough. So we need a special case for this
not exists(Value enum_convert | enum_convert = enum_class.attr("_convert")) and
exists(CallNode call | call.getScope() = m.getScope() |
call.getFunction().(AttrNode).getObject(["_convert", "_convert_"]).pointsTo() =