From 946d0358c95bdb93efeffb3ad3b03be85c032b8b Mon Sep 17 00:00:00 2001 From: Robert Marsh Date: Thu, 23 Jun 2022 15:59:34 +0000 Subject: [PATCH] Swift: remove check for inout params in SSA gen This check is unnecessary since it's enforced by the compiler, and is causing a bad join order. --- swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll | 1 - 1 file changed, 1 deletion(-) diff --git a/swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll b/swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll index ddf1cd4b254..687e3b2cef8 100644 --- a/swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll +++ b/swift/ql/lib/codeql/swift/dataflow/internal/SsaImplSpecific.qll @@ -32,7 +32,6 @@ predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain) exists(CallExpr call, Argument arg | arg.getExpr().(InOutExpr).getSubExpr() = v.getAnAccess() and call.getAnArgument() = arg and - call.getStaticTarget().getParam(arg.getIndex()).isInout() and bb.getNode(i).getNode().asAstNode() = call and certain = false )