hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 02:35:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

simplifications inspired by review

Browse Source
This commit is contained in:
erik-krogh
2023-01-13 13:18:52 +01:00
parent 43696f5e27
commit 71af8ab022
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javascript/ql/lib/semmle/javascript/ApiGraphs.qll
View File

@@ -210,12 +210,7 @@ module API {
* This is similar to `asSink()` but additionally includes nodes that transitively reach a sink by data flow.
* See `asSink()` for examples.
*/
DataFlow::Node getAValueReachingSink() {
result = Impl::trackDefNode(this.asSink())
or
// in case `asSink()` is not a `SourceNode`.
result = this.asSink()
}
DataFlow::Node getAValueReachingSink() { result = Impl::trackDefNode(this.asSink()) }
/** DEPRECATED. This predicate has been renamed to `asSink`. */
deprecated DataFlow::Node getARhs() { result = this.asSink() }

2
javascript/ql/lib/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll
View File

@@ -169,7 +169,7 @@ module UnsafeShellCommandConstruction {
or
exists(API::Node node |
node.asSink() = sys.getOptionsArg() and
node.getMember("shell").getAValueReachingSink().mayHaveBooleanValue(true)
node.getMember("shell").asSink().mayHaveBooleanValue(true)
)
}