hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review feedback

Browse Source
This commit is contained in:
Chris Smowton
2021-02-16 15:00:04 +00:00
parent a63f18e49d
commit 714611f803
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/semmle/code/java/frameworks/apache/Lang.qll
View File

@@ -122,14 +122,14 @@ private class ApacheStringUtilsTaintPreservingMethod extends TaintPreservingCall
/**
* A method declared on `org.apache.commons.lang3.text.StrBuilder`.
*/
abstract class ApacheStrBuilderMethod extends Callable {
class ApacheStrBuilderMethod extends Method {
ApacheStrBuilderMethod() {
this.getDeclaringType().hasQualifiedName("org.apache.commons.lang3.text", "StrBuilder")
}
}
/**
* An Apache Commons-Lang StrBuilder methods that add taint to the StrBuilder.
* An Apache Commons Lang StrBuilder method that adds taint to the StrBuilder.
*/
private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, TaintPreservingCallable {
ApacheStrBuilderTaintingMethod() {
@@ -170,7 +170,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai
}
/**
* An Apache Commons-Lang StrBuilder methods that return taint from the StrBuilder.
* An Apache Commons Lang StrBuilder method that returns taint from the StrBuilder.
*/
private class ApacheStrBuilderTaintGetter extends ApacheStrBuilderMethod, TaintPreservingCallable {
ApacheStrBuilderTaintGetter() {
@@ -188,7 +188,7 @@ private class ApacheStrBuilderTaintGetter extends ApacheStrBuilderMethod, TaintP
}
/**
* An Apache Commons-Lang StrBuilder methods that write taint from the StrBuilder to some parameter.
* An Apache Commons Lang StrBuilder method that writes taint from the StrBuilder to some parameter.
*/
private class ApacheStrBuilderTaintWriter extends ApacheStrBuilderMethod, TaintPreservingCallable {
ApacheStrBuilderTaintWriter() { this.hasName(["appendTo", "getChars"]) }