hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-25 00:27:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

PS: Us control-flow nodes in 'ReturnContainer' instead of dataflow nodes.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2024-10-11 11:59:44 +01:00
parent 76bd4150b4
commit 706eff2b14
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPrivate.qll
View File

@@ -494,7 +494,7 @@ private module ReturnNodes {
/**
* Gets a direct node that will may be returned when evaluating this node.
*/
Node getANode() { none() }
CfgNode getANode() { none() }
/** Gets a child that may produce more nodes that may be returned. */
abstract ReturnContainer getAChild();
@@ -503,7 +503,7 @@ private module ReturnNodes {
* Gets a (possibly transitive) node that may be returned when evaluating
* this node.
*/
final Node getAReturnedNode() {
final CfgNode getAReturnedNode() {
result = this.getANode()
or
result = this.getAChild().getAReturnedNode()
@@ -519,7 +519,7 @@ private module ReturnNodes {
}
class CmdExprReturnContainer extends ReturnContainer, CmdExpr {
final override ExprNode getANode() { result.getExprNode().getExpr() = this.getExpr() }
final override CfgNodes::ExprCfgNode getANode() { result.getExpr() = this.getExpr() }
final override ReturnContainer getAChild() { none() }
}
@@ -551,17 +551,25 @@ private module ReturnNodes {
}
class CmdBaseReturnContainer extends ReturnContainer, CmdExpr {
final override ExprNode getANode() { result.getExprNode().getExpr() = this.getExpr() }
final override CfgNodes::ExprCfgNode getANode() { result.getExpr() = this.getExpr() }
final override ReturnContainer getAChild() { none() }
}
class CmdReturnContainer extends ReturnContainer, Cmd {
final override StmtNode getANode() { result.getStmtNode().getStmt() = this }
final override CfgNodes::StmtCfgNode getANode() { result.getStmt() = this }
final override ReturnContainer getAChild() { none() }
}
/** Holds if `n` is returned from the enclosing callable. */
predicate isReturned(CfgNodes::AstCfgNode n) {
exists(ReturnContainer container |
container = n.getScope() and
n = container.getAReturnedNode()
)
}
class NormalReturnNode extends ReturnNode instanceof NodeImpl {
NormalReturnNode() {
exists(ReturnContainer container |