hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 17:23:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1403 from markshannon/python-builtin-inherit

Browse Source 
Python points-to: Make sure that builtin-classes inherit attributes.
This commit is contained in:
Taus
2019-06-05 17:40:10 +02:00
committed by GitHub
parent e11406ca90 8fadb64452
commit 703fbc6976
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
python/ql/src/analysis/Sanity.ql
View File

@@ -212,6 +212,15 @@ predicate file_sanity(string clsname, string problem, string what) {
)
}
predicate class_value_sanity(string clsname, string problem, string what) {
exists(ClassValue value |
exists(value.getASuperType().lookup(what)) and
not exists(value.lookup(what)) and
clsname = value.getAQlClass() and
problem = "is missing attribute that superclass has"
)
}
from string clsname, string problem, string what
where
ast_sanity(clsname, problem, what) or
@@ -224,5 +233,6 @@ source_object_sanity(clsname, problem, what) or
function_object_sanity(clsname, problem, what) or
points_to_sanity(clsname, problem, what) or
jump_to_definition_sanity(clsname, problem, what) or
file_sanity(clsname, problem, what)
file_sanity(clsname, problem, what) or
class_value_sanity(clsname, problem, what)
select clsname + " " + what + " has " + problem