hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 00:35:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Make File not extend Locatable anymore.

Browse Source 
Files have strange `:0:0:0:0` locations for... reasons. This makes the predicates inherited from `Locatable` meaningless. A particularly bad case is `getNumLines()`, which will always return one. The right predicate to use is, of course, `getNumberOfLines()`, which is defined in `File` itself.
This commit is contained in:
Max Schaefer
2019-11-22 11:57:06 +00:00
parent 46b6e6d722
commit 6fbaa7a5ea
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/src/semmle/javascript/Files.qll
View File

@@ -198,8 +198,8 @@ class Folder extends Container, @folder {
}
/** A file. */
class File extends Container, @file, Locatable {
override Location getLocation() { hasLocation(this, result) }
class File extends Container, @file {
Location getLocation() { hasLocation(this, result) }
override string getAbsolutePath() { files(this, result, _, _, _) }