hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: fix unused variable warning

Browse Source
This commit is contained in:
Robert Marsh
2019-01-31 13:32:24 -08:00
parent 726f38c802
commit 6f76c13385
2 changed files with 6 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasAnalysis.qll
View File

@@ -153,7 +153,7 @@ predicate operandIsPropagated(Operand operand, IntValue bitOffset) {
operandIsPropagated(operand, _) and not resultEscapes(operand.getUseInstruction())
or
// The operand is used in a function call from which the operand does not escape
exists(CallInstruction ci, FunctionIR f, Instruction init |
exists(CallInstruction ci, Instruction init |
ci = operand.getUseInstruction() and
isArgumentForParameter(ci, operand, init) and
not resultEscapesNonReturn(init) and
@@ -183,7 +183,7 @@ predicate operandEscapesNonReturn(Operand operand) {
not resultEscapesNonReturn(init) and
not resultEscapesNonReturn(ci)
) or
operand instanceof ReturnValueOperand
operand.getUseInstruction() instanceof ReturnValueInstruction
)
}
@@ -193,14 +193,6 @@ predicate operandReturned(Operand operand) {
operandIsPropagated(operand, _) and resultReturned(operand.getUseInstruction())
or
// The operand is used in a function call which returns it, and the return value is then returned
exists(CallInstruction ci, FunctionIR f, InitializeParameterInstruction ipi |
ci = operand.getUseInstruction() and
f.getFunction() = ci.getStaticCallTarget() and
ipi.getParameter() = f.getFunction().getParameter(operand.(PositionalArgumentOperand).getIndex()) and
resultReturned(ipi) and
resultReturned(ci)
)
or
exists(CallInstruction ci, Instruction init |
ci = operand.getUseInstruction() and
isArgumentForParameter(ci, operand, init) and
@@ -209,7 +201,7 @@ predicate operandReturned(Operand operand) {
)
or
// The address is returned
operand instanceof ReturnValueOperand
operand.getUseInstruction() instanceof ReturnValueInstruction
}
predicate isArgumentForParameter(CallInstruction ci, Operand operand, Instruction init) {

14
cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll
View File

@@ -153,7 +153,7 @@ predicate operandIsPropagated(Operand operand, IntValue bitOffset) {
operandIsPropagated(operand, _) and not resultEscapes(operand.getUseInstruction())
or
// The operand is used in a function call from which the operand does not escape
exists(CallInstruction ci, FunctionIR f, Instruction init |
exists(CallInstruction ci, Instruction init |
ci = operand.getUseInstruction() and
isArgumentForParameter(ci, operand, init) and
not resultEscapesNonReturn(init) and
@@ -183,7 +183,7 @@ predicate operandEscapesNonReturn(Operand operand) {
not resultEscapesNonReturn(init) and
not resultEscapesNonReturn(ci)
) or
operand instanceof ReturnValueOperand
operand.getUseInstruction() instanceof ReturnValueInstruction
)
}
@@ -193,14 +193,6 @@ predicate operandReturned(Operand operand) {
operandIsPropagated(operand, _) and resultReturned(operand.getUseInstruction())
or
// The operand is used in a function call which returns it, and the return value is then returned
exists(CallInstruction ci, FunctionIR f, InitializeParameterInstruction ipi |
ci = operand.getUseInstruction() and
f.getFunction() = ci.getStaticCallTarget() and
ipi.getParameter() = f.getFunction().getParameter(operand.(PositionalArgumentOperand).getIndex()) and
resultReturned(ipi) and
resultReturned(ci)
)
or
exists(CallInstruction ci, Instruction init |
ci = operand.getUseInstruction() and
isArgumentForParameter(ci, operand, init) and
@@ -209,7 +201,7 @@ predicate operandReturned(Operand operand) {
)
or
// The address is returned
operand instanceof ReturnValueOperand
operand.getUseInstruction() instanceof ReturnValueInstruction
}
predicate isArgumentForParameter(CallInstruction ci, Operand operand, Instruction init) {