hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve todo comment

Browse Source
This commit is contained in:
Tamas Vajk
2021-10-12 14:59:15 +02:00
committed by Ian Lynagh
parent ec889f933f
commit 6f3ae8da47
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/kotlin-extractor/src/main/kotlin/KotlinExtractorExtension.kt
View File

@@ -408,11 +408,10 @@ class KotlinFileExtractor(val logger: FileLogger, val tw: FileTrapWriter, val fi
}
fun useClass(c: IrClass, typeArgs: List<IrTypeArgument>): Label<out DbClassorinterface> {
// todo: this feels a bit arbitrary:
// It is introduced because the return type of a constructor is the type with its
// type parameters passed as type arguments.
// todo: investigate if this can only happen with constructor-like calls? If so, we could handle these there.
// todo: what happens with nested generics?
// todo: find a better way of finding if we're dealing with the source type.
// The return type of a constructor in a generic class is a simple type with the class as the classifier, and
// the type parameters added as type arguments. The same constructed source type can show up as parameter types
// of functions inside the class.
val args = if (typeArgsMatchTypeParameters(typeArgs, c.typeParameters)) {
listOf()
} else {