hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Javascript: fix errors from upcoming rules_java update

Browse Source
This commit is contained in:
Paolo Tranquilli
2025-11-11 11:52:36 +01:00
parent 8624f9c660
commit 6ef314ed03
18 changed files with 24 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/extractor/src/com/semmle/jcorn/Parser.java
View File

@@ -286,6 +286,7 @@ public class Parser {
raise(pos, msg, false);
}
@SuppressWarnings("ReturnValueIgnored")
protected void raise(Position loc, String msg, boolean recoverable) {
msg += " (" + loc.getLine() + ":" + loc.getColumn() + ")";
SyntaxError err = new SyntaxError(msg, loc, this.pos);
@@ -3114,7 +3115,7 @@ public class Parser {
}
first = false;
}
if (oldStrict == Boolean.FALSE) this.setStrict(false);
if (oldStrict.equals(Boolean.FALSE)) this.setStrict(false);
return this.finishNode(new BlockStatement(new SourceLocation(startLoc), body));
}

1
javascript/extractor/src/com/semmle/jcorn/flow/FlowParser.java
View File

@@ -141,6 +141,7 @@ public class FlowParser extends ESNextParser {
options.onRecoverableError(this.onRecoverableError);
}
@SuppressWarnings("ReturnValueIgnored")
private void commit() {
// commit buffered tokens
options.onToken(this.onToken);

4
javascript/extractor/src/com/semmle/js/ast/AFunctionExpression.java
View File

@@ -35,8 +35,8 @@ public abstract class AFunctionExpression extends Expression implements IFunctio
id,
params,
body,
generator == Boolean.TRUE,
async == Boolean.TRUE,
generator.equals(Boolean.TRUE),
async.equals(Boolean.TRUE),
typeParameters,
parameterTypes,
parameterDecorators,

2
javascript/extractor/src/com/semmle/js/ast/ComprehensionBlock.java
View File

@@ -10,7 +10,7 @@ public class ComprehensionBlock extends Expression {
super("ComprehensionBlock", loc);
this.left = left;
this.right = right;
this.of = of != Boolean.FALSE;
this.of = !of.equals(Boolean.FALSE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/ComprehensionExpression.java
View File

@@ -19,7 +19,7 @@ public class ComprehensionExpression extends Expression {
this.body = body;
this.blocks = blocks;
this.filter = filter;
this.generator = generator == Boolean.TRUE;
this.generator = generator.equals(Boolean.TRUE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/ForInStatement.java
View File

@@ -16,7 +16,7 @@ public class ForInStatement extends EnhancedForStatement {
public ForInStatement(
SourceLocation loc, Node left, Expression right, Statement body, Boolean each) {
super("ForInStatement", loc, left, right, body);
this.each = each == Boolean.TRUE;
this.each = each.equals(Boolean.TRUE);
}
public boolean isEach() {

4
javascript/extractor/src/com/semmle/js/ast/InvokeExpression.java
View File

@@ -27,8 +27,8 @@ public abstract class InvokeExpression extends Expression implements INodeWithSy
this.callee = callee;
this.typeArguments = typeArguments;
this.arguments = arguments;
this.optional = optional == Boolean.TRUE;
this.onOptionalChain = onOptionalChain == Boolean.TRUE;
this.optional = optional.equals(Boolean.TRUE);
this.onOptionalChain = onOptionalChain.equals(Boolean.TRUE);
}
/** The callee expression of this invocation. */

2
javascript/extractor/src/com/semmle/js/ast/Literal.java
View File

@@ -76,7 +76,7 @@ public class Literal extends Expression implements ITypeExpression {
if (isRegExp()) return false;
return value == null
|| value instanceof Number && ((Number) value).intValue() == 0
|| value == Boolean.FALSE
|| value.equals(Boolean.FALSE)
|| value instanceof String && ((String) value).isEmpty();
}

6
javascript/extractor/src/com/semmle/js/ast/MemberExpression.java
View File

@@ -22,9 +22,9 @@ public class MemberExpression extends Expression
super("MemberExpression", loc);
this.object = object;
this.property = property;
this.computed = computed == Boolean.TRUE;
this.optional = optional == Boolean.TRUE;
this.onOptionalChain = onOptionalChain == Boolean.TRUE;
this.computed = computed.equals(Boolean.TRUE);
this.optional = optional.equals(Boolean.TRUE);
this.onOptionalChain = onOptionalChain.equals(Boolean.TRUE);
}
@Override

4
javascript/extractor/src/com/semmle/js/ast/Property.java
View File

@@ -59,8 +59,8 @@ public class Property extends Node {
}
this.rawValue = rawValue;
this.kind = Kind.valueOf(StringUtil.uc(kind));
this.computed = computed == Boolean.TRUE;
this.method = method == Boolean.TRUE;
this.computed = computed.equals(Boolean.TRUE);
this.method = method.equals(Boolean.TRUE);
this.decorators = new ArrayList<Decorator>();
}

2
javascript/extractor/src/com/semmle/js/ast/TemplateElement.java
View File

@@ -10,7 +10,7 @@ public class TemplateElement extends Expression {
super("TemplateElement", loc);
this.cooked = cooked;
this.raw = raw;
this.tail = tail == Boolean.TRUE;
this.tail = tail.equals(Boolean.TRUE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/UnaryExpression.java
View File

@@ -14,7 +14,7 @@ public class UnaryExpression extends Expression {
super("UnaryExpression", loc);
this.operator = operator;
this.argument = argument;
this.prefix = prefix == Boolean.TRUE;
this.prefix = prefix.equals(Boolean.TRUE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/UpdateExpression.java
View File

@@ -11,7 +11,7 @@ public class UpdateExpression extends Expression {
super("UpdateExpression", loc);
this.operator = operator;
this.argument = argument;
this.prefix = prefix == Boolean.TRUE;
this.prefix = prefix.equals(Boolean.TRUE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/YieldExpression.java
View File

@@ -8,7 +8,7 @@ public class YieldExpression extends Expression {
public YieldExpression(SourceLocation loc, Expression argument, Boolean delegating) {
super("YieldExpression", loc);
this.argument = argument;
this.delegating = delegating == Boolean.TRUE;
this.delegating = delegating.equals(Boolean.TRUE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/jsdoc/FunctionType.java
View File

@@ -18,7 +18,7 @@ public class FunctionType extends JSDocTypeExpression {
JSDocTypeExpression result) {
super(loc, "FunctionType");
this._this = _this;
this._new = _new == Boolean.TRUE;
this._new = _new.equals(Boolean.TRUE);
this.params = params;
this.result = result;
}

2
javascript/extractor/src/com/semmle/js/ast/jsdoc/UnaryTypeConstructor.java
View File

@@ -19,7 +19,7 @@ public abstract class UnaryTypeConstructor extends JSDocTypeExpression {
String operator) {
super(loc, type);
this.expression = expression;
this.prefix = prefix == Boolean.TRUE;
this.prefix = prefix.equals(Boolean.TRUE);
this.operator = operator;
}

2
javascript/extractor/src/com/semmle/js/ast/regexp/CharacterClass.java
View File

@@ -11,7 +11,7 @@ public class CharacterClass extends RegExpTerm {
public CharacterClass(SourceLocation loc, List<RegExpTerm> elements, Boolean inverted) {
super(loc, "CharacterClass");
this.elements = elements;
this.inverted = inverted == Boolean.TRUE;
this.inverted = inverted.equals(Boolean.TRUE);
}
@Override

2
javascript/extractor/src/com/semmle/js/ast/regexp/Quantifier.java
View File

@@ -10,7 +10,7 @@ public abstract class Quantifier extends RegExpTerm {
public Quantifier(SourceLocation loc, String type, RegExpTerm operand, Boolean greedy) {
super(loc, type);
this.operand = operand;
this.greedy = greedy == Boolean.TRUE;
this.greedy = greedy.equals(Boolean.TRUE);
}
/** The quantified term. */