From 6ea6f30cc54487db852999081a52005e46b5c145 Mon Sep 17 00:00:00 2001
From: Paolo Tranquilli <redsun82@github.com>
Date: Wed, 3 Sep 2025 16:59:07 +0200
Subject: [PATCH] Bazel: fix `codeql_csharp_binary`

A `publish` directory for a C# binary contains copies of some DLLs
inside localized subdirectories (e.g. `ru`). We want to ignore those, as
otherwise our packaging machinery now goes haywire, with the newer
version of `rules_csharp`. In any case we never shipped those.
---
 misc/bazel/csharp.bzl | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/misc/bazel/csharp.bzl b/misc/bazel/csharp.bzl
index 2ba8c59f076..7a317909627 100644
--- a/misc/bazel/csharp.bzl
+++ b/misc/bazel/csharp.bzl
@@ -47,6 +47,30 @@ def codeql_xunit_test(name, **kwargs):
         **kwargs
     )
 
+def _filter_published_files_impl(ctx):
+    dir = ctx.attr.src[DefaultInfo].files_to_run.executable.dirname
+    files = ctx.attr.src[DefaultInfo].files.to_list()
+
+    # filter out all unneeded localization directories, that contain
+    # duplicate files that would break our packaging
+    files = [
+        f
+        for f in files
+        if f.dirname in (dir, dir + "/bin", dir + "\\bin")
+    ]
+    return [
+        DefaultInfo(
+            files = depset(files),
+        ),
+    ]
+
+_filter_published_files = rule(
+    implementation = _filter_published_files_impl,
+    attrs = {
+        "src": attr.label(),
+    },
+)
+
 def codeql_csharp_binary(name, **kwargs):
     kwargs.setdefault("nullable", "enable")
     kwargs.setdefault("target_frameworks", [TARGET_FRAMEWORK])
@@ -63,6 +87,7 @@ def codeql_csharp_binary(name, **kwargs):
 
     csharp_binary_target = "bin/" + name
     publish_binary_target = "publish/" + name
+    filtered_target = "filtered/" + name
     csharp_binary(name = csharp_binary_target, srcs = srcs, resources = resources, visibility = visibility, **kwargs)
     publish_binary(
         name = publish_binary_target,
@@ -76,10 +101,14 @@ def codeql_csharp_binary(name, **kwargs):
             },
         ),
     )
+    _filter_published_files(
+        name = filtered_target,
+        src = publish_binary_target,
+    )
 
     codeql_pkg_files(
         name = name,
-        exes = [publish_binary_target],
+        exes = [filtered_target],
         prefix = "tools/{CODEQL_PLATFORM}",
         strip_prefix = strip_prefix.files_only(),
         visibility = visibility,