hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Improve nonReturningFunction.

Browse Source
This commit is contained in:
Geoffrey White
2018-10-26 16:06:47 +01:00
parent 1a6229621c
commit 6e940d7bf2
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cpp/ql/src/semmle/code/cpp/controlflow/internal/ConstantExprs.qll
View File

@@ -138,13 +138,15 @@ private predicate impossibleDefaultSwitchEdge(Block switchBlock, DefaultCase dc)
/**
* Holds if the function `f` never returns due to not containing a return
* statement (explicit or compiler generated). Reachability of return
* statement (explicit or compiler generated). This can be thought of as
* a lightweight `potentiallyReturningFunction`- reachability of return
* statements is not checked.
*/
private predicate nonReturningFunction(Function f)
{
exists(f.getBlock()) and
not exists(ReturnStmt ret | ret.getEnclosingFunction() = f)
not exists(ReturnStmt ret | ret.getEnclosingFunction() = f) and
not getOptions().exits(f)
}
/**
@@ -152,6 +154,7 @@ private predicate nonReturningFunction(Function f)
*/
private predicate impossibleFunctionReturn(FunctionCall fc, Node succ) {
nonReturningFunction(fc.getTarget()) and
not fc.isVirtual() and
successors_extended(fc, succ)
}