diff --git a/java/ql/lib/semmle/code/java/security/regexp/NfaUtilsSpecific.qll b/java/ql/lib/semmle/code/java/security/regexp/NfaUtilsSpecific.qll index d72d6770848..742229eacca 100644 --- a/java/ql/lib/semmle/code/java/security/regexp/NfaUtilsSpecific.qll +++ b/java/ql/lib/semmle/code/java/security/regexp/NfaUtilsSpecific.qll @@ -61,7 +61,7 @@ module RegExpFlags { /** * Gets the flags for `root`, or the empty string if `root` has no flags. */ - string getFlags(RegExpTerm root) { + deprecated string getFlags(RegExpTerm root) { root.isRootTerm() and result = root.getLiteral().getFlags() } diff --git a/java/ql/src/Violations of Best Practice/Naming Conventions/Shadowing.qll b/java/ql/src/Violations of Best Practice/Naming Conventions/Shadowing.qll index 0451956977e..e58016bdff9 100644 --- a/java/ql/src/Violations of Best Practice/Naming Conventions/Shadowing.qll +++ b/java/ql/src/Violations of Best Practice/Naming Conventions/Shadowing.qll @@ -1,9 +1,5 @@ import java -predicate initializedToField(LocalVariableDecl d, Field f) { - exists(LocalVariableDeclExpr e | e.getVariable() = d and f.getAnAccess() = e.getInit()) -} - predicate getterFor(Method m, Field f) { m.getName().matches("get%") and m.getDeclaringType() = f.getDeclaringType() and