hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-24 16:17:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Add missing overrides.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2026-05-12 11:29:30 +01:00
parent e77d85f23e
commit 6d5d57acca
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaImpl.qll
View File

@@ -1357,6 +1357,16 @@ class PhiNode extends Definition instanceof SsaImpl::PhiNode {
final predicate hasInputFromBlock(Definition input, IRBlock bb) {
phiHasInputFromBlock(this, input, bb)
}
override int getIndirection() { result = this.getSourceVariable().getIndirection() }
override predicate isCertain() {
forex(Definition inp | inp = this.getAnInput() | inp.isCertain())
}
final override Declaration getFunction() {
result = SsaImpl::PhiNode.super.getBasicBlock().getEnclosingFunction()
}
}
/** An static single assignment (SSA) definition. */

4
cpp/ql/test/library-tests/dataflow/certain/test.cpp
View File

@@ -28,7 +28,7 @@ void test2(bool b) { // $ certain="SSA def(&b)" certain="SSA def(b)"
} else {
x = 1; // $ certain="SSA def(x)"
}
use(x); // $ uncertain="SSA phi(x)"
use(x); // $ certain="SSA phi(x)"
}
{
@@ -38,7 +38,7 @@ void test2(bool b) { // $ certain="SSA def(&b)" certain="SSA def(b)"
} else {
}
use(x); // $ uncertain="SSA phi(x)"
use(x); // $ certain="SSA phi(x)"
}
{