C#: Replace getLocation() with hasLocationInfo() in Attributable

csharp/ql/src/Useless code/DefaultToString.ql

@@ -10,70 +10,4 @@
  *       maintainability
  */
 
-import csharp
-import semmle.code.csharp.commons.Strings
-import semmle.code.csharp.frameworks.System
-
-/**
- * Holds if expression `e`, of type `t`, invokes `ToString()` either explicitly
- * or implicitly.
- */
-predicate invokesToString(Expr e, ValueOrRefType t) {
-  // Explicit invocation
-  exists(MethodCall mc | mc.getQualifier() = e |
-    mc.getTarget() instanceof ToStringMethod and
-    t = mc.getQualifier().getType()
-  )
-  or
-  // Explicit or implicit invocation
-  e instanceof ImplicitToStringExpr and
-  t = e.stripCasts().getType()
-  or
-  // Implicit invocation via forwarder method
-  t = e.stripCasts().getType() and
-  not t instanceof StringType and
-  exists(AssignableDefinitions::ImplicitParameterDefinition def, Parameter p, ParameterRead pr |
-    e = p.getAnAssignedArgument()
-  |
-    def.getParameter() = p and
-    pr = def.getAReachableRead() and
-    pr.getAControlFlowNode().postDominates(p.getCallable().getEntryPoint()) and
-    invokesToString(pr, _)
-  )
-}
-
-/**
- * Holds if `t`, or any sub type of `t`, inherits the default `ToString()`
- * method from `System.Object` or `System.ValueType`.
- */
-predicate alwaysDefaultToString(ValueOrRefType t) {
-  exists(ToStringMethod m | t.hasMethod(m) |
-    m.getDeclaringType() instanceof SystemObjectClass or
-    m.getDeclaringType() instanceof SystemValueTypeClass
-  ) and
-  not exists(RefType overriding |
-    overriding.getAMethod() instanceof ToStringMethod and
-    overriding.getABaseType+() = t
-  ) and
-  ((t.isAbstract() or t instanceof Interface) implies not t.isEffectivelyPublic())
-}
-
-class DefaultToStringType extends ValueOrRefType {
-  DefaultToStringType() { alwaysDefaultToString(this) }
-
-  // A workaround for generating empty URLs for non-source locations, because qltest
-  // does not support non-source locations
-  override Location getLocation() {
-    result = super.getLocation() and
-    result instanceof SourceLocation
-    or
-    not super.getLocation() instanceof SourceLocation and
-    result instanceof EmptyLocation
-  }
-}
-
-from Expr e, DefaultToStringType t
-where invokesToString(e, t)
-select e,
-  "Default 'ToString()': $@ inherits 'ToString()' from 'Object', and so is not suitable for printing.",
-  t, t.getName()
+import DefaultToString