hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16650 from alexrford/rb/routing-improvements

Browse Source 
Ruby: ActionDispatch - support `path => target` route format
This commit is contained in:
Alex Ford
2024-06-18 11:17:05 +01:00
committed by GitHub
parent 33704779ea 1100b75a3c
commit 6c3d90e8a0
4 changed files with 138 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
ruby/ql/test/library-tests/frameworks/action_dispatch/ActionDispatch.expected
View File

@@ -1,6 +1,6 @@
actionDispatchRoutes
| app/config/routes.rb:2:3:8:5 | call to resources | get | posts | posts | index |
| app/config/routes.rb:2:3:8:5 | call to resources | get | posts/:id | posts | show |
| app/config/routes.rb:2:3:9:5 | call to resources | get | posts | posts | index |
| app/config/routes.rb:2:3:9:5 | call to resources | get | posts/:id | posts | show |
| app/config/routes.rb:3:5:6:7 | call to resources | delete | posts/:post_id/comments/:id | comments | destroy |
| app/config/routes.rb:3:5:6:7 | call to resources | get | posts/:post_id/comments | comments | index |
| app/config/routes.rb:3:5:6:7 | call to resources | get | posts/:post_id/comments/:id | comments | show |
@@ -12,38 +12,40 @@ actionDispatchRoutes
| app/config/routes.rb:4:7:4:41 | call to resources | post | posts/:post_id/comments/:comment_id/replies | replies | create |
| app/config/routes.rb:5:7:5:28 | call to post | post | posts/:post_id/comments/:comment_id/flag | comments | flag |
| app/config/routes.rb:7:5:7:37 | call to post | post | posts/:post_id/upvote | posts | upvote |
| app/config/routes.rb:11:5:11:54 | call to post | post | destroy_all_posts | posts | destroy_alll |
| app/config/routes.rb:15:5:15:46 | call to get | get | numbers/:number | numbers | show |
| app/config/routes.rb:19:5:19:44 | call to get | get | admin/jobs | background_jobs | index |
| app/config/routes.rb:23:5:23:64 | call to get | get | admin/secrets | secrets | view_secrets |
| app/config/routes.rb:24:5:24:42 | call to delete | delete | admin/:user_id | users | destroy |
| app/config/routes.rb:27:3:27:48 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:28:3:28:50 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:29:3:29:69 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:30:3:30:50 | call to match | delete | photos/:id | photos | show |
| app/config/routes.rb:30:3:30:50 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:30:3:30:50 | call to match | patch | photos/:id | photos | show |
| app/config/routes.rb:30:3:30:50 | call to match | post | photos/:id | photos | show |
| app/config/routes.rb:30:3:30:50 | call to match | put | photos/:id | photos | show |
| app/config/routes.rb:33:5:33:43 | call to post | post | upgrade | users | start_upgrade |
| app/config/routes.rb:37:5:37:31 | call to get | get | current_billing_cycle | billing/enterprise | current_billing_cycle |
| app/config/routes.rb:40:3:40:40 | call to resource | get | global_config | global_config | show |
| app/config/routes.rb:43:5:45:7 | call to resources | get | foo/bar | foo/bar | index |
| app/config/routes.rb:43:5:45:7 | call to resources | get | foo/bar/:id | foo/bar | show |
| app/config/routes.rb:44:7:44:39 | call to get | get | foo/bar/:bar_id/show_debug | foo/bar | show_debug |
| app/config/routes.rb:49:5:49:95 | call to delete | delete | users/:user/notifications | users/notifications | destroy |
| app/config/routes.rb:50:5:50:94 | call to post | post | users/:user/notifications/:notification_id/mark_as_read | users/notifications | mark_as_read |
| app/config/routes.rb:8:5:8:39 | call to post | post | posts/:post_id | posts | downvote |
| app/config/routes.rb:12:5:12:54 | call to post | post | destroy_all_posts | posts | destroy_alll |
| app/config/routes.rb:16:5:16:46 | call to get | get | numbers/:number | numbers | show |
| app/config/routes.rb:20:5:20:44 | call to get | get | admin/jobs | background_jobs | index |
| app/config/routes.rb:24:5:24:64 | call to get | get | admin/secrets | secrets | view_secrets |
| app/config/routes.rb:25:5:25:42 | call to delete | delete | admin/:user_id | users | destroy |
| app/config/routes.rb:28:3:28:48 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:29:3:29:50 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:30:3:30:69 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:31:3:31:50 | call to match | delete | photos/:id | photos | show |
| app/config/routes.rb:31:3:31:50 | call to match | get | photos/:id | photos | show |
| app/config/routes.rb:31:3:31:50 | call to match | patch | photos/:id | photos | show |
| app/config/routes.rb:31:3:31:50 | call to match | post | photos/:id | photos | show |
| app/config/routes.rb:31:3:31:50 | call to match | put | photos/:id | photos | show |
| app/config/routes.rb:34:5:34:43 | call to post | post | upgrade | users | start_upgrade |
| app/config/routes.rb:38:5:38:31 | call to get | get | current_billing_cycle | billing/enterprise | current_billing_cycle |
| app/config/routes.rb:41:3:41:40 | call to resource | get | global_config | global_config | show |
| app/config/routes.rb:44:5:46:7 | call to resources | get | foo/bar | foo/bar | index |
| app/config/routes.rb:44:5:46:7 | call to resources | get | foo/bar/:id | foo/bar | show |
| app/config/routes.rb:45:7:45:39 | call to get | get | foo/bar/:bar_id/show_debug | foo/bar | show_debug |
| app/config/routes.rb:50:5:50:95 | call to delete | delete | users/:user/notifications | users/notifications | destroy |
| app/config/routes.rb:51:5:51:94 | call to post | post | users/:user/notifications/:notification_id/mark_as_read | users/notifications | mark_as_read |
actionDispatchControllerMethods
| app/config/routes.rb:2:3:8:5 | call to resources | app/controllers/posts_controller.rb:2:3:3:5 | index |
| app/config/routes.rb:2:3:8:5 | call to resources | app/controllers/posts_controller.rb:5:3:6:5 | show |
| app/config/routes.rb:2:3:9:5 | call to resources | app/controllers/posts_controller.rb:2:3:3:5 | index |
| app/config/routes.rb:2:3:9:5 | call to resources | app/controllers/posts_controller.rb:5:3:6:5 | show |
| app/config/routes.rb:3:5:6:7 | call to resources | app/controllers/comments_controller.rb:2:3:39:5 | index |
| app/config/routes.rb:3:5:6:7 | call to resources | app/controllers/comments_controller.rb:41:3:42:5 | show |
| app/config/routes.rb:7:5:7:37 | call to post | app/controllers/posts_controller.rb:8:3:9:5 | upvote |
| app/config/routes.rb:27:3:27:48 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:28:3:28:50 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:29:3:29:69 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:30:3:30:50 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:50:5:50:94 | call to post | app/controllers/users/notifications_controller.rb:3:5:4:7 | mark_as_read |
| app/config/routes.rb:8:5:8:39 | call to post | app/controllers/posts_controller.rb:11:3:12:5 | downvote |
| app/config/routes.rb:28:3:28:48 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:29:3:29:50 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:30:3:30:69 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:31:3:31:50 | call to match | app/controllers/photos_controller.rb:2:3:3:5 | show |
| app/config/routes.rb:51:5:51:94 | call to post | app/controllers/users/notifications_controller.rb:3:5:4:7 | mark_as_read |
underscore
| Foo | foo |
| Foo::Bar | foo/bar |

1
ruby/ql/test/library-tests/frameworks/action_dispatch/app/config/routes.rb
View File

@@ -5,6 +5,7 @@ Rails.application.routes.draw do
post "flag", to: :flag
end
post "upvote", to: "posts#upvote"
post "downvote" => "posts#downvote"
end
if Rails.env.test?

7
ruby/ql/test/library-tests/frameworks/action_dispatch/app/controllers/posts_controller.rb
View File

@@ -4,7 +4,10 @@ class PostsController < ApplicationController
def show
end
def upvote
end
end
def downvote
end
end