Python: Port old fabric tests

For v1 tests, just extended with explicit calls that use keyword arguments.

For v2 tests, rewrote pretty much everything to what it 100% explicit what we support

python/ql/test/experimental/library-tests/frameworks/fabric/ConceptsTest.expected

@@ -0,0 +1,21 @@
+| fabric_v1_test.py:8:22:8:47 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v1_test.py:9:20:9:45 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v1_test.py:10:21:10:46 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v1_test.py:12:30:12:55 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v1_test.py:13:28:13:53 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v1_test.py:14:29:14:54 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:13:22:13:47 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:14:24:14:49 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:15:23:15:48 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:17:32:17:57 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:18:30:18:55 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:19:31:19:56 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:23:23:23:48 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:29:66:29:91 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:32:25:32:50 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:35:62:35:87 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:41:69:41:94 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:44:25:44:50 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:47:65:47:90 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:58:26:58:51 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |
+| fabric_v2_test.py:64:26:64:51 | Comment # $getCommand="cmd1; cmd2" | Missing result:getCommand="cmd1; cmd2" |

python/ql/test/experimental/library-tests/frameworks/fabric/ConceptsTest.ql

@@ -0,0 +1,2 @@
+import python
+import experimental.meta.ConceptsTest

python/ql/test/experimental/library-tests/frameworks/fabric/TestTaint.expected

@@ -0,0 +1,10 @@
+| fabric_v1_execute.py:7 | fail | unsafe | cmd |
+| fabric_v1_execute.py:7 | fail | unsafe | cmd2 |
+| fabric_v1_execute.py:8 | ok   | unsafe | safe_arg |
+| fabric_v1_execute.py:8 | ok   | unsafe | safe_optional |
+| fabric_v1_execute.py:14 | fail | unsafe | cmd |
+| fabric_v1_execute.py:14 | fail | unsafe | cmd2 |
+| fabric_v1_execute.py:15 | ok   | unsafe | safe_arg |
+| fabric_v1_execute.py:15 | ok   | unsafe | safe_optional |
+| fabric_v1_execute.py:21 | ok   | some_http_handler | cmd |
+| fabric_v1_execute.py:21 | ok   | some_http_handler | cmd2 |

python/ql/test/experimental/library-tests/frameworks/fabric/TestTaint.ql

@@ -0,0 +1 @@
+import experimental.dataflow.tainttracking.TestTaintLib

python/ql/test/experimental/library-tests/frameworks/fabric/fabric_v1_execute.py

@@ -0,0 +1,26 @@
+"""Test that shows fabric.api.execute propagates taint"""
+
+from fabric.api import run, execute
+
+
+def unsafe(cmd, safe_arg, cmd2=None, safe_optional=5):
+    ensure_tainted(cmd, cmd2)
+    ensure_not_tainted(safe_arg, safe_optional)
+
+
+class Foo(object):
+
+    def unsafe(self, cmd, safe_arg, cmd2=None, safe_optional=5):
+        ensure_tainted(cmd, cmd2)
+        ensure_not_tainted(safe_arg, safe_optional)
+
+
+def some_http_handler():
+    cmd = TAINTED_STRING
+    cmd2 = TAINTED_STRING
+    ensure_tainted(cmd, cmd2)
+
+    execute(unsafe, cmd=cmd, safe_arg='safe_arg', cmd2=cmd2)
+
+    foo = Foo()
+    execute(foo.unsafe, cmd, 'safe_arg', cmd2)

python/ql/test/experimental/library-tests/frameworks/fabric/fabric_v1_test.py

@@ -0,0 +1,14 @@
+"""tests for the 'fabric' package (v1.x)
+
+See http://docs.fabfile.org/en/1.14/tutorial.html
+"""
+
+from fabric.api import run, local, sudo
+
+local("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+sudo("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+local(command="cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+run(command="cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+sudo(command="cmd1; cmd2")  # $getCommand="cmd1; cmd2"

python/ql/test/experimental/library-tests/frameworks/fabric/fabric_v2_test.py

@@ -0,0 +1,64 @@
+"""tests for the 'fabric' package (v2.x)
+
+Loosely inspired by http://docs.fabfile.org/en/2.5/getting-started.html
+"""
+
+from fabric import connection, Connection, group, SerialGroup, ThreadingGroup, tasks, task
+
+
+################################################################################
+# Connection
+################################################################################
+c = Connection("web1")
+c.run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+c.local("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+c.sudo("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+c.local(command="cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+c.run(command="cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+c.sudo(command="cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+# fully qualified usage
+c2 = connection.Connection("web2")
+c2.run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+
+################################################################################
+# SerialGroup
+################################################################################
+results = SerialGroup("web1", "web2", "mac1").run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+pool = SerialGroup("web1", "web2", "web3")
+pool.run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+# fully qualified usage
+group.SerialGroup("web1", "web2", "mac1").run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+
+################################################################################
+# ThreadingGroup
+################################################################################
+results = ThreadingGroup("web1", "web2", "mac1").run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+pool = ThreadingGroup("web1", "web2", "web3")
+pool.run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+# fully qualified usage
+group.ThreadingGroup("web1", "web2", "mac1").run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+
+################################################################################
+# task decorator
+# using the 'fab' command-line tool
+################################################################################
+
+@task
+def foo(c):
+    # 'c' is a fabric.connection.Connection
+    c.run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"
+
+# fully qualified usage
+@tasks.task
+def bar(c):
+    # 'c' is a fabric.connection.Connection
+    c.run("cmd1; cmd2")  # $getCommand="cmd1; cmd2"