From 6b1bbf16aaa6afd34295d2c0826c3fd6863728f0 Mon Sep 17 00:00:00 2001 From: Slavomir Date: Tue, 4 Aug 2020 16:01:30 +0300 Subject: [PATCH] Remove taint-tracking for objects that implement io.Reader --- ql/src/semmle/go/frameworks/stdlib/Bufio.qll | 4 ---- ql/src/semmle/go/frameworks/stdlib/Bytes.qll | 8 -------- 2 files changed, 12 deletions(-) diff --git a/ql/src/semmle/go/frameworks/stdlib/Bufio.qll b/ql/src/semmle/go/frameworks/stdlib/Bufio.qll index f025be68065..b4cb8b2519e 100644 --- a/ql/src/semmle/go/frameworks/stdlib/Bufio.qll +++ b/ql/src/semmle/go/frameworks/stdlib/Bufio.qll @@ -69,10 +69,6 @@ module Bufio { this.(Method).hasQualifiedName("bufio", "Reader", "Peek") and (inp.isReceiver() and outp.isResult(0)) or - // signature: func (*Reader).Read(p []byte) (n int, err error) - this.(Method).hasQualifiedName("bufio", "Reader", "Read") and - (inp.isReceiver() and outp.isParameter(0)) - or // signature: func (*Reader).ReadByte() (byte, error) this.(Method).hasQualifiedName("bufio", "Reader", "ReadByte") and (inp.isReceiver() and outp.isResult(0)) diff --git a/ql/src/semmle/go/frameworks/stdlib/Bytes.qll b/ql/src/semmle/go/frameworks/stdlib/Bytes.qll index e29b95a003a..28bd4614501 100644 --- a/ql/src/semmle/go/frameworks/stdlib/Bytes.qll +++ b/ql/src/semmle/go/frameworks/stdlib/Bytes.qll @@ -159,10 +159,6 @@ module Bytes { this.(Method).hasQualifiedName("bytes", "Buffer", "Next") and (inp.isReceiver() and outp.isResult()) or - // signature: func (*Buffer).Read(p []byte) (n int, err error) - this.(Method).hasQualifiedName("bytes", "Buffer", "Read") and - (inp.isReceiver() and outp.isParameter(0)) - or // signature: func (*Buffer).ReadByte() (byte, error) this.(Method).hasQualifiedName("bytes", "Buffer", "ReadByte") and (inp.isReceiver() and outp.isResult(0)) @@ -207,10 +203,6 @@ module Bytes { this.(Method).hasQualifiedName("bytes", "Buffer", "WriteTo") and (inp.isReceiver() and outp.isParameter(0)) or - // signature: func (*Reader).Read(b []byte) (n int, err error) - this.(Method).hasQualifiedName("bytes", "Reader", "Read") and - (inp.isReceiver() and outp.isParameter(0)) - or // signature: func (*Reader).ReadAt(b []byte, off int64) (n int, err error) this.(Method).hasQualifiedName("bytes", "Reader", "ReadAt") and (inp.isReceiver() and outp.isParameter(0))