hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply code review suggestions

Browse Source
This commit is contained in:
Tony Torralba
2022-01-19 15:48:56 +01:00
parent 57ff13dd19
commit 6a4d2ee850
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/lib/semmle/code/java/dataflow/FlowSources.qll
View File

@@ -271,7 +271,7 @@ class ExportedAndroidContentProviderInput extends RemoteFlowSource, AndroidConte
* calls `startActivityForResult` with an implicit Intent.
*/
class OnActivityResultIntentSource extends OnActivityResultIncomingIntent, RemoteFlowSource {
OnActivityResultIntentSource() { isRemoteSource() }
OnActivityResultIntentSource() { this.isRemoteSource() }
override string getSourceType() { result = "Android onActivityResult incoming Intent" }
}

7
java/ql/lib/semmle/code/java/frameworks/android/OnActivityResultSource.qll
View File

@@ -42,11 +42,14 @@ class OnActivityResultIncomingIntent extends DataFlow::Node {
// and the activity it belongs to defines `onActivityResult`.
exists(MethodAccess ma |
ma.getMethod().hasName(["add", "attach", "replace"]) and
ma.getMethod().getDeclaringType().hasName("FragmentTransaction") and
ma.getMethod().getDeclaringType().hasQualifiedName("android.app", "FragmentTransaction") and
any(Argument arg | arg = ma.getAnArgument()).getType() = startingType
or
ma.getMethod().hasName("show") and
ma.getMethod().getDeclaringType().getASupertype*().hasName("DialogFragment") and
ma.getMethod()
.getDeclaringType()
.getASupertype*()
.hasQualifiedName("android.app", "DialogFragment") and
startingType = ma.getQualifier().getType()
|
ma.getEnclosingCallable().getDeclaringType() =