hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up sink definition

Browse Source
This commit is contained in:
Joe Farebrother
2021-09-14 17:52:13 +01:00
parent daf6ac2584
commit 6a2346ec33
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/semmle/code/java/security/AndroidSensitiveBroadcastQuery.qll
View File

@@ -55,7 +55,7 @@ private predicate isEmptyArrayArg(Expr ex) {
*/ */
private predicate isSensitiveBroadcastSink(DataFlow::Node sink) { private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
exists(SendBroadcastMethodAccess ma, string name | ma.getMethod().hasName(name) | exists(SendBroadcastMethodAccess ma, string name | ma.getMethod().hasName(name) |
sink.asExpr() = ma.getAnArgument() and sink.asExpr() = ma.getArgument(0) and
( (
name = "sendBroadcast" and name = "sendBroadcast" and
( (
@@ -85,7 +85,7 @@ private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
// sendOrderedBroadcast(Intent intent, String receiverPermission) // sendOrderedBroadcast(Intent intent, String receiverPermission)
// sendOrderedBroadcast(Intent intent, String receiverPermission, BroadcastReceiver resultReceiver, Handler scheduler, int initialCode, String initialData, Bundle initialExtras) // sendOrderedBroadcast(Intent intent, String receiverPermission, BroadcastReceiver resultReceiver, Handler scheduler, int initialCode, String initialData, Bundle initialExtras)
isNullArg(ma.getArgument(1)) and isNullArg(ma.getArgument(1)) and
ma.getNumArgument() <= 7 ma.getNumArgument() = [2, 7]
or or
// sendOrderedBroadcast(Intent intent, String receiverPermission, String receiverAppOp, BroadcastReceiver resultReceiver, Handler scheduler, int initialCode, String initialData, Bundle initialExtras) // sendOrderedBroadcast(Intent intent, String receiverPermission, String receiverAppOp, BroadcastReceiver resultReceiver, Handler scheduler, int initialCode, String initialData, Bundle initialExtras)
isNullArg(ma.getArgument(1)) and isNullArg(ma.getArgument(1)) and