hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: More precise detection of classes with escaping instances

Browse Source
This commit is contained in:
Asger F
2024-02-29 11:10:52 +01:00
parent eeaa2bcc55
commit 6a0adff1dc
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
javascript/ql/lib/semmle/javascript/endpoints/EndpointNaming.qll
View File

@@ -277,9 +277,16 @@ private predicate nameFromGlobal(DataFlow::Node node, string package, string nam
(if node.getTopLevel().isExterns() then badness = -10 else badness = 10)
}
/** Gets an API node whose value is exposed to client code. */
private API::Node exposedNode() {
result = API::moduleExport(_)
or
result = exposedNode().getASuccessor()
}
/** Holds if an instance of `cls` can be exposed to client code. */
private predicate hasEscapingInstance(DataFlow::ClassNode cls) {
cls.getAnInstanceReference().flowsTo(any(API::Node n).asSink())
cls.getAnInstanceReference().flowsTo(exposedNode().asSink())
}
private predicate sourceNodeHasNameCandidate(

1
javascript/ql/test/library-tests/EndpointNaming/EndpointNaming.expected
View File

@@ -1,5 +1,4 @@
testFailures
| pack1/main.js:19:6:19:10 | | Unexpected result: name=(pack1).InternalClass.prototype.m |
ambiguousPreferredPredecessor
| pack2/lib.js:1:1:3:1 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getInstance() |
| pack2/lib.js:8:22:8:34 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getMember("foo") |