Java: Re-factor provenance related predicates for summarized callable.

2026-04-27 09:45:15 +02:00 · 2022-12-16 13:36:32 +01:00
parent ea173f9516
commit 6a047d6916
2 changed files with 23 additions and 36 deletions
--- a/java/ql/src/Metrics/Summaries/GeneratedVsManualCoverage.ql
+++ b/java/ql/src/Metrics/Summaries/GeneratedVsManualCoverage.ql
@@ -26,15 +26,16 @@ private int getNumMadModeledApis(string package, string provenance) {
        sc.isAutoGenerated() and
        provenance = "generated"
        or
-        // "manual-only"
-        sc.hasProvenance(false) and
-        not sc.hasProvenance(true) and
-        provenance = "manual"
-        or
-        // "both"
-        sc.hasProvenance(false) and
-        sc.hasProvenance(true) and
-        provenance = "both"
+        sc.isManual() and
+        (
+          if sc.hasProvenance("generated")
+          then
+            // "both"
+            provenance = "both"
+          else
+            // "manual-only"
+            provenance = "manual"
+        )
      )
    )
 }