hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-19 02:13:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Fix ql4ql alerts

Browse Source 
The rest will be ignored.
This commit is contained in:
Rasmus Wriedt Larsen
2022-11-22 16:24:47 +01:00
parent 00ec3a23ba
commit 69b43f147a
3 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
python/ql/src/Security/CWE-020-ExternalAPIs/ExternalAPIs.qll
View File

@@ -157,11 +157,10 @@ class UnresolvedCall extends InterestingExternalApiCall, TUnresolvedCall {
/** A node representing data being passed to an external API through a call. */
class ExternalApiDataNode extends DataFlow::Node {
InterestingExternalApiCall call;
DataFlowPrivate::ArgumentPosition apos;
ExternalApiDataNode() {
this = call.getArgument(apos) and
exists(InterestingExternalApiCall call, DataFlowPrivate::ArgumentPosition apos |
this = call.getArgument(apos)
) and
// Not already modeled as a taint step
not exists(DataFlow::Node next | TaintTrackingPrivate::defaultAdditionalTaintStep(this, next)) and
// for `list.append(x)`, we have a additional taint step from x -> [post] list.

4
python/ql/src/meta/analysis-quality/CallGraphQuality.qll
View File

@@ -81,7 +81,7 @@ module PointsToBasedCallGraph {
*/
class ResolvableCallRelevantTarget extends ResolvableCall {
ResolvableCallRelevantTarget() {
exists(Target target | target = getTarget() |
exists(Target target | target = this.getTarget() |
exists(target.getLocation().getFile().getRelativePath())
)
}
@@ -137,7 +137,7 @@ module TypeTrackingBasedCallGraph {
*/
class ResolvableCallRelevantTarget extends ResolvableCall {
ResolvableCallRelevantTarget() {
exists(Target target | target = getTarget() |
exists(Target target | target = this.getTarget() |
exists(target.getLocation().getFile().getRelativePath())
)
}