diff --git a/change-notes/1.19/analysis-python.md b/change-notes/1.19/analysis-python.md index 2c179e98a34..9e8c3d25a6b 100644 --- a/change-notes/1.19/analysis-python.md +++ b/change-notes/1.19/analysis-python.md @@ -57,7 +57,7 @@ A new predicate `Stmt.getAnEntryNode()` has been added to make it easier to writ | **Query** | **Tags** | **Purpose** | |-----------------------------|-----------|--------------------------------------------------------------------| | Information exposure through an exception (`py/stack-trace-exposure`) | security, external/cwe/cwe-209, external/cwe/cwe-497 | Finds instances where information about an exception may be leaked to an external user. Enabled on LGTM by default. | -| Request Without Certificate Validation (`py/request-without-cert-validation`) | security, external/cwe/cwe-295 | Finds requests where certificate verification has been explicitly turned off, possibly allowing man-in-the-middle attacks. Not enabled on LGTM by default. | +| Request without certificate validation (`py/request-without-cert-validation`) | security, external/cwe/cwe-295 | Finds requests where certificate verification has been explicitly turned off, possibly allowing man-in-the-middle attacks. Not enabled on LGTM by default. | ## Changes to existing queries diff --git a/python/ql/src/Security/CWE-295/RequestWithoutValidation.qhelp b/python/ql/src/Security/CWE-295/RequestWithoutValidation.qhelp index 1b178f105c3..b581c4f4a01 100644 --- a/python/ql/src/Security/CWE-295/RequestWithoutValidation.qhelp +++ b/python/ql/src/Security/CWE-295/RequestWithoutValidation.qhelp @@ -6,9 +6,9 @@

Encryption is key to the security of most, if not all, online communication. -Using TLS can enusre that neither party in the communication is an interloper. +Using Transport Layer Security (TLS) can ensure that communication cannot be interrupted by an interloper. For this reason, is is unwise to disable the verification that TLS provides. -requests provides verification by default, and it is only when +Functions in the requests module provide verification by default, and it is only when explicitly turned off using verify=False that no verification occurs.

@@ -29,10 +29,6 @@ The example shows two unsafe calls to semmle.com
  • -Common Weakness Enumeration: -CWE-295: Improper Certificate Validation. -
  • -
  • Python requests documentation: SSL Cert Verification.
  • diff --git a/python/ql/src/Security/CWE-295/RequestWithoutValidation.ql b/python/ql/src/Security/CWE-295/RequestWithoutValidation.ql index 213f2f13975..4413a986704 100644 --- a/python/ql/src/Security/CWE-295/RequestWithoutValidation.ql +++ b/python/ql/src/Security/CWE-295/RequestWithoutValidation.ql @@ -1,5 +1,5 @@ /** - * @name Request Without Certificate Validation + * @name Request without certificate validation * @description Making a request without certificate validation can allow man-in-the-middle attacks. * @kind problem * @problem.severity error