C++: Address review comments.

2025-12-24 04:36:35 +01:00 · 2022-03-08 13:15:02 +00:00
parent 1bf430529b
commit 69417e150a
3 changed files with 27 additions and 0 deletions
--- a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/MustFlow.qll
+++ b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/MustFlow.qll
@@ -177,6 +177,11 @@ private module Cached {
    operand.getDef() = instr
  }

+  /**
+   * Holds if data flows from `operand` to `instr`.
+   *
+   * This predicate ignores flow through `PhiInstruction`s to create a 'must flow' relation.
+   */
  private predicate operandToInstructionStep(Operand operand, Instruction instr) {
    instr.(CopyInstruction).getSourceValueOperand() = operand
    or