hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove false positive in missingSpaceInAppend by requring the presence of a word-like fragment

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-09-25 13:34:18 +02:00
parent b85896299d
commit 69365ccd03
5 changed files with 54 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
javascript/ql/test/query-tests/Expressions/MissingSpaceInAppend/MissingSpaceInAppend.expected
View File

@@ -11,3 +11,4 @@
| missing.js:24:5:24:21 | `missing a space` | This string appears to be missing a space after 'space'. |
| missing.js:26:5:26:21 | "missing a space" | This string appears to be missing a space after 'space'. |
| missing.js:28:5:28:21 | `missing a space` | This string appears to be missing a space after 'space'. |
| missing.js:31:7:31:12 | "h. 0" | This string appears to be missing a space after '0'. |

2
javascript/ql/test/query-tests/Expressions/MissingSpaceInAppend/missing.js
View File

@@ -27,3 +27,5 @@ s = "missing a space" +
`here`;
s = `missing a space` +
`here`;
s = (("h. 0" + "h")) + "word"

5
javascript/ql/test/query-tests/Expressions/MissingSpaceInAppend/ok.js
View File

@@ -8,4 +8,7 @@ s = "the class java.util." +
s = "some data: a,b,c," +
"d,e,f";
s = "overflow: scroll;" +
"position: absolute;";
"position: absolute;";
s = "h. 0" + "h"
s = ((("h. 0"))) + (("h")) + ("h")