patch upper-case acronyms to be PascalCase

cpp/ql/test/library-tests/dataflow/DefaultTaintTracking/annotate_path_to_sink/tainted.ql

@@ -67,8 +67,8 @@ class IRDefaultTaintTrackingTest extends InlineExpectationsTest {
   }
 }
 
-class ASTTaintTrackingTest extends InlineExpectationsTest {
-  ASTTaintTrackingTest() { this = "ASTTaintTrackingTest" }
+class AstTaintTrackingTest extends InlineExpectationsTest {
+  AstTaintTrackingTest() { this = "ASTTaintTrackingTest" }
 
   override string getARelevantTag() { result = "ast" }
 

cpp/ql/test/library-tests/dataflow/DefaultTaintTracking/annotate_sinks_only/tainted.ql

@@ -55,8 +55,8 @@ class IRDefaultTaintTrackingTest extends InlineExpectationsTest {
   }
 }
 
-class ASTTaintTrackingTest extends InlineExpectationsTest {
-  ASTTaintTrackingTest() { this = "ASTTaintTrackingTest" }
+class AstTaintTrackingTest extends InlineExpectationsTest {
+  AstTaintTrackingTest() { this = "ASTTaintTrackingTest" }
 
   override string getARelevantTag() { result = "ast" }
 

cpp/ql/test/library-tests/dataflow/DefaultTaintTracking/globals/global.ql

@@ -27,8 +27,8 @@ class IRGlobalDefaultTaintTrackingTest extends InlineExpectationsTest {
   }
 }
 
-class ASTGlobalDefaultTaintTrackingTest extends InlineExpectationsTest {
-  ASTGlobalDefaultTaintTrackingTest() { this = "ASTGlobalDefaultTaintTrackingTest" }
+class AstGlobalDefaultTaintTrackingTest extends InlineExpectationsTest {
+  AstGlobalDefaultTaintTrackingTest() { this = "ASTGlobalDefaultTaintTrackingTest" }
 
   override string getARelevantTag() { result = "ast" }
 

cpp/ql/test/library-tests/dataflow/dataflow-tests/test.ql

@@ -1,6 +1,6 @@
 import TestUtilities.dataflow.FlowTestCommon
 
-module ASTTest {
+module AstTest {
   private import semmle.code.cpp.dataflow.DataFlow
 
   /**
@@ -18,8 +18,8 @@ module ASTTest {
   }
 
   /** Common data flow configuration to be used by tests. */
-  class ASTTestAllocationConfig extends DataFlow::Configuration {
-    ASTTestAllocationConfig() { this = "ASTTestAllocationConfig" }
+  class AstTestAllocationConfig extends DataFlow::Configuration {
+    AstTestAllocationConfig() { this = "ASTTestAllocationConfig" }
 
     override predicate isSource(DataFlow::Node source) {
       source.asExpr().(FunctionCall).getTarget().getName() = "source"
@@ -100,10 +100,10 @@ module IRTest {
   }
 
   private predicate readsVariable(LoadInstruction load, Variable var) {
-    load.getSourceAddress().(VariableAddressInstruction).getASTVariable() = var
+    load.getSourceAddress().(VariableAddressInstruction).getAstVariable() = var
   }
 
   private predicate writesVariable(StoreInstruction store, Variable var) {
-    store.getDestinationAddress().(VariableAddressInstruction).getASTVariable() = var
+    store.getDestinationAddress().(VariableAddressInstruction).getAstVariable() = var
   }
 }

cpp/ql/test/library-tests/dataflow/fields/ASTConfiguration.qll

@@ -1,8 +1,8 @@
 private import semmle.code.cpp.dataflow.DataFlow
 private import DataFlow
 
-class ASTConf extends Configuration {
-  ASTConf() { this = "ASTFieldFlowConf" }
+class AstConf extends Configuration {
+  AstConf() { this = "ASTFieldFlowConf" }
 
   override predicate isSource(Node src) {
     src.asExpr() instanceof NewExpr
@@ -30,3 +30,6 @@ class ASTConf extends Configuration {
     b.asExpr().(AddressOfExpr).getOperand() = a.asExpr()
   }
 }
+
+/** DEPRECATED: Alias for AstConf */
+deprecated class ASTConf = AstConf;

cpp/ql/test/library-tests/dataflow/fields/Nodes.qll

@@ -3,7 +3,7 @@ private import semmle.code.cpp.dataflow.DataFlow as AST
 private import cpp
 
 private newtype TNode =
-  TASTNode(AST::DataFlow::Node n) or
+  TAstNode(AST::DataFlow::Node n) or
   TIRNode(IR::DataFlow::Node n)
 
 class Node extends TNode {
@@ -11,23 +11,32 @@ class Node extends TNode {
 
   IR::DataFlow::Node asIR() { none() }
 
-  AST::DataFlow::Node asAST() { none() }
+  AST::DataFlow::Node asAst() { none() }
+
+  /** DEPRECATED: Alias for asAst */
+  deprecated AST::DataFlow::Node asAST() { result = asAst() }
 
   Location getLocation() { none() }
 }
 
-class ASTNode extends Node, TASTNode {
+class AstNode extends Node, TAstNode {
   AST::DataFlow::Node n;
 
-  ASTNode() { this = TASTNode(n) }
+  AstNode() { this = TAstNode(n) }
 
   override string toString() { result = n.toString() }
 
-  override AST::DataFlow::Node asAST() { result = n }
+  override AST::DataFlow::Node asAst() { result = n }
+
+  /** DEPRECATED: Alias for asAst */
+  deprecated override AST::DataFlow::Node asAST() { result = asAst() }
 
   override Location getLocation() { result = n.getLocation() }
 }
 
+/** DEPRECATED: Alias for AstNode */
+deprecated class ASTNode = AstNode;
+
 class IRNode extends Node, TIRNode {
   IR::DataFlow::Node n;
 

cpp/ql/test/library-tests/dataflow/fields/flow.ql

@@ -1,6 +1,6 @@
 import TestUtilities.dataflow.FlowTestCommon
 
-module ASTTest {
+module AstTest {
   private import ASTConfiguration
 }
 

cpp/ql/test/library-tests/dataflow/fields/partial-definition-diff.ql

@@ -7,8 +7,8 @@ import semmle.code.cpp.ir.dataflow.DataFlow::DataFlow as IR
 import semmle.code.cpp.dataflow.DataFlow::DataFlow as AST
 import Nodes
 
-class ASTPartialDefNode extends ASTNode {
-  ASTPartialDefNode() { exists(n.asPartialDefinition()) }
+class AstPartialDefNode extends AstNode {
+  AstPartialDefNode() { exists(n.asPartialDefinition()) }
 
   override string toString() { result = n.asPartialDefinition().toString() }
 }
@@ -29,7 +29,7 @@ where
   msg = "IR only"
   or
   exists(AST::Node astNode, Expr partial |
-    node.asAST() = astNode and
+    node.asAst() = astNode and
     partial = astNode.asPartialDefinition() and
     not exists(IR::Node otherNode | otherNode.asPartialDefinition() = partial)
   ) and

cpp/ql/test/library-tests/dataflow/fields/path-flow.ql

@@ -7,6 +7,6 @@ import ASTConfiguration
 import cpp
 import DataFlow::PathGraph
 
-from DataFlow::PathNode src, DataFlow::PathNode sink, ASTConf conf
+from DataFlow::PathNode src, DataFlow::PathNode sink, AstConf conf
 where conf.hasFlowPath(src, sink)
 select sink, src, sink, sink + " flows from $@", src, src.toString()

cpp/ql/test/library-tests/dataflow/smart-pointers-taint/taint.ql

@@ -1,10 +1,10 @@
 import TestUtilities.dataflow.FlowTestCommon
 
-module ASTTest {
+module AstTest {
   private import semmle.code.cpp.dataflow.TaintTracking
 
-  class ASTSmartPointerTaintConfig extends TaintTracking::Configuration {
-    ASTSmartPointerTaintConfig() { this = "ASTSmartPointerTaintConfig" }
+  class AstSmartPointerTaintConfig extends TaintTracking::Configuration {
+    AstSmartPointerTaintConfig() { this = "ASTSmartPointerTaintConfig" }
 
     override predicate isSource(DataFlow::Node source) {
       source.asExpr().(FunctionCall).getTarget().getName() = "source"

cpp/ql/test/library-tests/dataflow/taint-tests/taint.ql

@@ -38,13 +38,13 @@ module TaintModels {
   }
 }
 
-module ASTTest {
+module AstTest {
   private import semmle.code.cpp.dataflow.TaintTracking
   private import semmle.code.cpp.models.interfaces.Taint
 
   /** Common data flow configuration to be used by tests. */
-  class ASTTestAllocationConfig extends TaintTracking::Configuration {
-    ASTTestAllocationConfig() { this = "ASTTestAllocationConfig" }
+  class AstTestAllocationConfig extends TaintTracking::Configuration {
+    AstTestAllocationConfig() { this = "ASTTestAllocationConfig" }
 
     override predicate isSource(DataFlow::Node source) {
       source.asExpr().(FunctionCall).getTarget().getName() = "source"