hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 00:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove a few getExtensibleType checks which are now unnecessary.

Browse Source
This commit is contained in:
Max Schaefer
2024-01-15 11:50:59 +00:00
parent 919330fb53
commit 68cf9aca12
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/automodel/src/AutomodelApplicationModeCharacteristics.qll
View File

@@ -520,8 +520,7 @@ private class NonPublicMethodCharacteristic extends CharacteristicsImpl::Uninter
NonPublicMethodCharacteristic() { this = "non-public method" }
override predicate appliesToEndpoint(Endpoint e) {
e.getExtensibleType() = "sinkModel" and
not e.getCallable().isPublic()
exists(Callable c | c = e.getCallable() | not c.isPublic())
}
}
@@ -543,7 +542,6 @@ private class OtherArgumentToModeledMethodCharacteristic extends Characteristics
}
override predicate appliesToEndpoint(Endpoint e) {
e.getExtensibleType() = "sinkModel" and
not ApplicationCandidatesImpl::isSink(e, _, _) and
exists(CallArgument otherSink |
ApplicationCandidatesImpl::isSink(otherSink, _, "manual") and
@@ -562,7 +560,6 @@ private class FunctionValueCharacteristic extends CharacteristicsImpl::LikelyNot
FunctionValueCharacteristic() { this = "function value" }
override predicate appliesToEndpoint(Endpoint e) {
e.getExtensibleType() = "sinkModel" and
e.asNode().asExpr() instanceof FunctionalExpr
}
}
@@ -579,7 +576,6 @@ private class CannotBeTaintedCharacteristic extends CharacteristicsImpl::LikelyN
CannotBeTaintedCharacteristic() { this = "cannot be tainted" }
override predicate appliesToEndpoint(Endpoint e) {
e.getExtensibleType() = "sinkModel" and
not this.isKnownOutNodeForStep(e)
}