hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: refactor isManuallyGenerated and isBothAutoAndManuallyGenerated

Browse Source
This commit is contained in:
Jami Cogswell
2022-12-09 18:37:50 -05:00
parent 0b2f2a3f88
commit 6854845b75
6 changed files with 36 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
python/ql/lib/semmle/python/dataflow/new/internal/FlowSummaryImpl.qll
View File

@@ -1001,20 +1001,6 @@ module Private {
not summaryElement(this, _, _, _, false)
}
private predicate relevantSummaryElementManual(
AccessPath inSpec, AccessPath outSpec, string kind
) {
summaryElement(this, inSpec, outSpec, kind, false) and
not summaryElement(this, _, _, _, true)
}
private predicate relevantSummaryElementBothGeneratedAndManual(
AccessPath inSpec, AccessPath outSpec, string kind
) {
summaryElement(this, inSpec, outSpec, kind, true) and
summaryElement(this, inSpec, outSpec, kind, false)
}
private predicate relevantSummaryElement(AccessPath inSpec, AccessPath outSpec, string kind) {
summaryElement(this, inSpec, outSpec, kind, false)
or
@@ -1037,10 +1023,14 @@ module Private {
override predicate isAutoGenerated() { this.relevantSummaryElementGenerated(_, _, _) }
override predicate isManuallyGenerated() { this.relevantSummaryElementManual(_, _, _) }
override predicate isManuallyGenerated() {
summaryElement(this, _, _, _, false) and
not summaryElement(this, _, _, _, true)
}
override predicate isBothAutoAndManuallyGenerated() {
this.relevantSummaryElementBothGeneratedAndManual(_, _, _)
summaryElement(this, _, _, _, true) and
summaryElement(this, _, _, _, false)
}
}