hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 09:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Dataflow: Fix another bad join order.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2021-05-31 15:14:13 +02:00
parent 017bf68906
commit 683f853fa5
24 changed files with 288 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowImpl.qll
View File

@@ -841,9 +841,10 @@ private module Stage2 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -1515,9 +1516,10 @@ private module Stage3 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -2270,9 +2272,10 @@ private module Stage4 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**

21
csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowImpl2.qll
View File

@@ -841,9 +841,10 @@ private module Stage2 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -1515,9 +1516,10 @@ private module Stage3 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -2270,9 +2272,10 @@ private module Stage4 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**

21
csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowImpl3.qll
View File

@@ -841,9 +841,10 @@ private module Stage2 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -1515,9 +1516,10 @@ private module Stage3 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -2270,9 +2272,10 @@ private module Stage4 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**

21
csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowImpl4.qll
View File

@@ -841,9 +841,10 @@ private module Stage2 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -1515,9 +1516,10 @@ private module Stage3 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -2270,9 +2272,10 @@ private module Stage4 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**

21
csharp/ql/src/semmle/code/csharp/dataflow/internal/DataFlowImpl5.qll
View File

@@ -841,9 +841,10 @@ private module Stage2 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -1515,9 +1516,10 @@ private module Stage3 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**
@@ -2270,9 +2272,10 @@ private module Stage4 {
DataFlowCall call, ReturnNodeExt node1, Node node2, boolean allowsFieldFlow,
Configuration config
) {
flowOutOfCall(call, node1, node2, allowsFieldFlow, config) and
PrevStage::callMayFlowThroughRev(call, config) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _, config)
flowOutOfCall(call, node1, node2, allowsFieldFlow, pragma[only_bind_into](config)) and
PrevStage::callMayFlowThroughRev(call, pragma[only_bind_into](config)) and
PrevStage::parameterMayFlowThrough(_, getNodeEnclosingCallable(node1), _,
pragma[only_bind_into](config))
}
/**