hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 18:25:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: move shared conjunct up

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2018-12-04 10:54:36 +01:00
parent a342fa36c6
commit 679db191f5
1 changed files with 16 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
javascript/ql/src/semmle/javascript/frameworks/React.qll
View File

@@ -200,17 +200,14 @@ abstract class ReactComponent extends ASTNode {
callback = getAMethodCall("setState").getCallback(0) and
stateParameterIndex = 0
or
// componentDidUpdate: (prevProps, prevState)
callback = getInstanceMethod("componentDidUpdate").flow() and
stateParameterIndex = 1
or
// getDerivedStateFromProps: (props, state)
callback = getStaticMethod("getDerivedStateFromProps").flow() and
stateParameterIndex = 1
or
// getSnapshotBeforeUpdate: (prevProps, prevState)
callback = getInstanceMethod("getSnapshotBeforeUpdate").flow() and
stateParameterIndex = 1
stateParameterIndex = 1 and (
// componentDidUpdate: (prevProps, prevState)
callback = getInstanceMethod("componentDidUpdate").flow() or
// getDerivedStateFromProps: (props, state)
callback = getStaticMethod("getDerivedStateFromProps").flow() or
// getSnapshotBeforeUpdate: (prevProps, prevState)
callback = getInstanceMethod("getSnapshotBeforeUpdate").flow()
)
)
}
@@ -255,18 +252,14 @@ abstract class ReactComponent extends ASTNode {
callback = getAMethodCall("setState").getCallback(0) and
propsParameterIndex = 1
or
// componentDidUpdate: (prevProps, prevState)
callback = getInstanceMethod("componentDidUpdate").flow() and
propsParameterIndex = 0
or
// getDerivedStateFromProps: (props, state)
callback = getStaticMethod("getDerivedStateFromProps").flow() and
propsParameterIndex = 0
or
// getSnapshotBeforeUpdate: (prevProps, prevState)
callback = getInstanceMethod("getSnapshotBeforeUpdate").flow() and
propsParameterIndex = 0
propsParameterIndex = 0 and (
// componentDidUpdate: (prevProps, prevState)
callback = getInstanceMethod("componentDidUpdate").flow() or
// getDerivedStateFromProps: (props, state)
callback = getStaticMethod("getDerivedStateFromProps").flow() or
// getSnapshotBeforeUpdate: (prevProps, prevState)
callback = getInstanceMethod("getSnapshotBeforeUpdate").flow()
)
)
}