hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reused isGetPredicate to retrieve the prefix of the predicate

Browse Source
This commit is contained in:
Napalys
2024-12-02 09:10:54 +01:00
parent 7c1aa84459
commit 67745e6332
1 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
ql/ql/src/queries/style/ValidatePredicateGetReturns.ql
View File

@@ -16,7 +16,9 @@ import codeql_ql.ast.Ast
* Identifies predicates whose names start with "get", "as" followed by an uppercase letter.
* This ensures that only predicates like "getValue" are matched, excluding names like "getter".
*/
predicate isGetPredicate(Predicate pred) { pred.getName().regexpMatch("(get|as)[A-Z].*") }
predicate isGetPredicate(Predicate pred, string prefix) {
prefix = pred.getName().regexpCapture("(get|as)[A-Z].*", 1)
}
/**
* Checks if a predicate has a return type.
@@ -28,21 +30,9 @@ predicate hasReturnType(Predicate pred) { exists(pred.getReturnTypeExpr()) }
*/
predicate isAlias(Predicate pred) { exists(pred.(ClasslessPredicate).getAlias()) }
/**
* Returns "get" if the predicate name starts with "get", otherwise "as".
*/
string getPrefix(Predicate pred) {
if pred.getName().matches("get%")
then result = "get"
else
if pred.getName().matches("as%")
then result = "as"
else result = ""
}
from Predicate pred
from Predicate pred, string prefix
where
isGetPredicate(pred) and
isGetPredicate(pred, prefix) and
not hasReturnType(pred) and
not isAlias(pred)
select pred, "This predicate starts with '" + getPrefix(pred) + "' but does not return a value."
select pred, "This predicate starts with '" + prefix + "' but does not return a value."