hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: do not add read steps for collections

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2023-06-01 15:18:05 +02:00
parent 9cb83fcdc9
commit 6755bb32fb
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
python/ql/lib/semmle/python/dataflow/new/internal/TaintTrackingPrivate.qll
View File

@@ -202,19 +202,6 @@ predicate containerStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
obj = nodeTo.(DataFlow::PostUpdateNode).getPreUpdateNode() and
call.getArg(0) = nodeFrom
)
or
// Although flow through collections is modeled precisely using stores/reads, we still
// allow flow out of a _tainted_ collection. This is needed in order to support taint-
// tracking configurations where the source is a collection.
exists(DataFlow::Content c | DataFlowPrivate::readStep(nodeFrom, c, nodeTo) |
// c instanceof DataFlow::ListElementContent
// or
// c instanceof DataFlow::SetElementContent
// or
c instanceof DataFlow::DictionaryElementContent
// or
// c instanceof DataFlow::DictionaryElementAnyContent
)
}
/**