hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 11:16:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Ruby: improve non-constant-kernel-open, recursive step for freeze

Browse Source 
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
This commit is contained in:
Peter Stöckli
2023-04-19 10:50:59 +02:00
committed by GitHub
parent 2f268b309b
commit 672cb92fbd
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ruby/ql/src/queries/security/cwe-078/NonConstantKernelOpen.ql
View File

@@ -37,7 +37,7 @@ predicate hasConstantPrefix(DataFlow::Node node) {
node.asExpr().getExpr().(StringlikeLiteral).getComponent(0) instanceof StringTextComponent
or
// it is not a constant string argument
exists(node.asExpr().getExpr().getConstantValue())
exists(node.getConstantValue())
or
// not a concatenation that starts with a constant string
exists(DataFlow::ExprNode prefix |
@@ -46,5 +46,13 @@ predicate hasConstantPrefix(DataFlow::Node node) {
)
or
// is a .freeze call on a constant string
node.asExpr().getExpr().(ConstantReadAccess).getValue().(MethodCall).getMethodName() = "freeze"
exists(DataFlow::CallNode call | node = call and call.getMethodName() = "freeze" |
hasConstantPrefix(call.getReceiver())
)
or
// is a constant read of a constant string
exists(DataFlow::Node constant |
constant.asExpr().getExpr() = node.asExpr().getExpr().(ConstantReadAccess).getValue() and
hasConstantPrefix(constant)
)
}