hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 19:55:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Apply suggestions from code review

Browse Source 
Co-authored-by: Taus <tausbn@github.com>
This commit is contained in:
Rasmus Wriedt Larsen
2021-03-05 17:08:37 +01:00
committed by GitHub
parent 83539928e6
commit 66c9cfad85
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
python/ql/src/Security/CVE-2018-1281/BindToAllInterfaces.ql
View File

@@ -54,10 +54,7 @@ DataFlow::Node vulnerableHostname(string hostname) {
/** Gets a reference to tuple containing a hostname as the first element, that can be used to bind to all interfaces. */
private DataFlow::LocalSourceNode vulnerableAddressTuple(DataFlow::TypeTracker t, string hostname) {
t.start() and
exists(Tuple tup |
tup.getElt(0) = vulnerableHostname(hostname).asExpr() and
result.asExpr() = tup
)
result.asExpr() = any(Tuple tup | tup.getElt(0) = vulnerableHostname(hostname).asExpr())
or
// Due to bad performance when using normal setup with `vulnerableAddressTuple(t2, hostname).track(t2, t)`
// we have inlined that code and forced a join