hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Produce friendlier message for empty-string replacements.

Browse Source
This commit is contained in:
Max Schaefer
2018-09-25 11:03:05 +01:00
parent 5fb22ba021
commit 659c67c715
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javascript/ql/src/RegExp/IdentityReplacement.ql
View File

@@ -60,8 +60,9 @@ predicate regExpMatchesString(RegExpTerm t, string s) {
)
}
from MethodCallExpr repl, string s
from MethodCallExpr repl, string s, string friendly
where repl.getMethodName() = "replace" and
matchesString(repl.getArgument(0), s) and
repl.getArgument(1).getStringValue() = s
select repl.getArgument(0), "This replaces '" + s + "' with itself."
repl.getArgument(1).getStringValue() = s and
(if s = "" then friendly = "the empty string" else friendly = "'" + s + "'")
select repl.getArgument(0), "This replaces " + friendly + " with itself."