hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-05 15:16:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Refactor EnvInput to MaD

Browse Source
This commit is contained in:
Edward Minnix III
2023-09-02 13:23:48 -04:00
committed by Ed Minnix
parent d258f69ab0
commit 655470f3da
4 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/lib/semmle/code/java/dataflow/FlowSources.qll
View File

@@ -233,10 +233,7 @@ deprecated class EnvInput extends DataFlow::Node {
* environment variables.
*/
private class EnvironmentInput extends LocalUserInput {
EnvironmentInput() {
// Results from various specific methods.
this.asExpr().(MethodAccess).getMethod() instanceof EnvReadMethod
}
EnvironmentInput() { sourceNode(this, "environment") }
override string getThreatModel() { result = "environment" }
}
@@ -268,10 +265,7 @@ private class CliInput extends LocalUserInput {
private class FileInput extends LocalUserInput {
FileInput() {
// Access to files.
this.asExpr()
.(ConstructorCall)
.getConstructedType()
.hasQualifiedName("java.io", "FileInputStream")
sourceNode(this, "file")
}
override string getThreatModel() { result = "file" }