Merge pull request #18735 from asgerf/inline-test-non-location

Test: Support arbitrary locations in inline test post-processor
This commit is contained in:
Asger F
2025-02-12 10:30:50 +01:00
committed by GitHub
4 changed files with 118 additions and 26 deletions

View File

@@ -2,4 +2,4 @@
| duplicates.js:6:33:6:56 | functio ... up2b){} | This function has a duplicate dependency $@. | duplicates.js:6:24:6:30 | 'dup2a' | dup2a |
| duplicates.js:7:33:7:56 | functio ... up3b){} | This function has a duplicate dependency $@. | duplicates.js:7:24:7:30 | 'dup3b' | dup3b |
| duplicates.js:8:43:8:78 | functio ... up4C){} | This function has a duplicate dependency $@. | duplicates.js:8:35:8:40 | 'dup4' | dup4 |
| duplicates.js:15:35:15:112 | functio ... } | This function has a duplicate dependency $@. | duplicates.js:15:25:15:32 | 'dup11a' | dup11a |
| duplicates.js:15:35:15:113 | functio ... } | This function has a duplicate dependency $@. | duplicates.js:15:25:15:32 | 'dup11a' | dup11a |

View File

@@ -1 +1,2 @@
AngularJS/DuplicateDependency.ql
query: AngularJS/DuplicateDependency.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql

View File

@@ -1,18 +1,18 @@
(function(){
function f(){}
f.$inject = ['dup5', 'dup5']; // NOT OK
function f(){} // $ Alert
f.$inject = ['dup5', 'dup5'];
angular.module('myModule', [])
.run(['dup1a', 'dup1a', function(dup1a, dup1a){}]) // OK (flagged by js/duplicate-parameter-name)
.run(['dup2a', 'dup2a', function(dup2a, dup2b){}]) // NOT OK
.run(['dup3b', 'dup3b', function(dup3a, dup3b){}]) // NOT OK
.run(['dup4', 'notDup4A', 'dup4', function(notDup4B, dup4, notDup4C){}]) // NOT OK
.run(['dup1a', 'dup1a', function(dup1a, dup1a){}]) // OK - flagged by js/duplicate-parameter-name
.run(['dup2a', 'dup2a', function(dup2a, dup2b){}]) // $ Alert
.run(['dup3b', 'dup3b', function(dup3a, dup3b){}]) // $ Alert
.run(['dup4', 'notDup4A', 'dup4', function(notDup4B, dup4, notDup4C){}]) // $ Alert
.run(f)
.run(function(dup6, dup6){})// OK (flagged by js/duplicate-parameter-name)
.run(function(notDup7a, notDup7b){}) // OK
.run(['notDup8a', 'notDup8b', function(notDup8a, notDup8b){}]) // OK
.run(['notDup9a', 'notDup9b', function(notDup9c, notDup9d){}]) // OK
.run(['dup10a', 'dup10a', 'dup10a', function(dup10a, dup10a, dup10a){}]) // OK (flagged by js/duplicate-parameter-name)
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // NOT OK (alert formatting for multi-line function)
.run(function(dup6, dup6){})// OK - flagged by js/duplicate-parameter-name
.run(function(notDup7a, notDup7b){})
.run(['notDup8a', 'notDup8b', function(notDup8a, notDup8b){}])
.run(['notDup9a', 'notDup9b', function(notDup9c, notDup9d){}])
.run(['dup10a', 'dup10a', 'dup10a', function(dup10a, dup10a, dup10a){}]) // OK - flagged by js/duplicate-parameter-name
.run(['dup11a', 'dup11a', function(dup11a, dup11b){ // $ Alert - alert formatting for multi-line function
}])
;
})();