hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Chris Smowton <smowton@github.com>
This commit is contained in:
Jonathan Leitschuh
2022-03-09 10:25:05 -05:00
committed by GitHub
parent 2e8b5f743b
commit 65457cc2e2
2 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/lib/change-notes/2022-03-07-char-literal-in-compile-time-constant.md
View File

@@ -1,5 +1,5 @@
---
category: minorAnalysis
---
* Add new method `CharacterLiteral.getStringifiedValue` which attempts to compute the
`String.valueOf` compile time constant value of the expression.
* Add new method `CompileTimeConstantExpr.getStringifiedValue` which attempts to compute the
`String.valueOf` string rendering of a constant expression.

14
java/ql/lib/semmle/code/java/Expr.qll
View File

@@ -201,17 +201,9 @@ class CompileTimeConstantExpr extends Expr {
result = this.(StringLiteral).getValue()
or
(
if this.(AddExpr).getAnOperand().getType() instanceof TypeString // If either operand type is already a String:
then
// Then the stringified version of the expression can be safely used as a String will be created.
result =
this.(AddExpr).getLeftOperand().(CompileTimeConstantExpr).getStringifiedValue() +
this.(AddExpr).getRightOperand().(CompileTimeConstantExpr).getStringifiedValue()
else
// Adding two literals of primitive type will not result in a String.
result =
this.(AddExpr).getLeftOperand().(CompileTimeConstantExpr).getStringValue() +
this.(AddExpr).getRightOperand().(CompileTimeConstantExpr).getStringValue()
this.getType() instanceof TypeString and
this.(AddExpr).getLeftOperand().(CompileTimeConstantExpr).getStringifiedValue() +
this.(AddExpr).getRightOperand().(CompileTimeConstantExpr).getStringifiedValue()
)
or
// Ternary conditional, with compile-time constant condition.