Apply suggestions from code review

Co-authored-by: Arthur Baars <aibaars@github.com>

ql/src/codeql_ruby/ast/Class.qll

@@ -65,11 +65,6 @@ class Class extends ExprSequence {
    */
   final Method getAMethod() { result = this.getAnExpr() }
 
-  /**
-   * DEPRECATED: temporary placeholder until we have a `ConstantAccess` class.
-   */
-  deprecated final string getSuperclassName() { result = range.getSuperclassName() }
-
   /**
    * Gets the `Expr` used as the superclass in the class definition, if any.
    *
@@ -205,14 +200,4 @@ class Module extends ExprSequence, @module {
    */
   final Method getAMethod() { result = this.getAnExpr() }
 
-  /**
-   * Gets a class defined in this module.
-   * ```rb
-   * module Foo
-   *   class Bar
-   *   end
-   * end
-   * ```
-   */
-  final Class getAClass() { result = this.getAnExpr() }
 }

ql/src/codeql_ruby/ast/internal/Class.qll

@@ -15,11 +15,6 @@ module Class {
 
     final ScopeResolution getNameScopeResolution() { result = generated.getName() }
 
-    final string getSuperclassName() {
-      result = generated.getSuperclass().getChild().(Generated::Token).getValue() or
-      result = generated.getSuperclass().getChild().(ScopeResolution).getName()
-    }
-
     final Expr getSuperclassExpr() { result = generated.getSuperclass().getChild() }
   }
 }
@@ -32,8 +27,6 @@ module SingletonClass {
 
     final Expr getValue() { result = generated.getValue() }
 
-    // TODO: delete me
-    final AstNode getAstNodeValue() { result = generated.getValue() }
   }
 }