renamed "isComputed" to "is_computed"

javascript/extractor/src/com/semmle/js/ast/DeclarationFlags.java

@@ -37,7 +37,7 @@ public class DeclarationFlags {
 
   public static final List<String> relationNames =
       Arrays.asList(
-          "isComputed",
+          "is_computed",
           "isAbstractMember",
           "isStatic",
           "hasReadonlyKeyword",

javascript/extractor/src/com/semmle/js/extractor/ASTExtractor.java

@@ -1132,7 +1132,7 @@ public class ASTExtractor {
       visit(nd.getKey(), propkey, 0, nd.isComputed() ? IdContext.varBind : IdContext.label);
       visit(nd.getValue(), propkey, 1, c.idcontext);
       visit(nd.getDefaultValue(), propkey, 2, IdContext.varBind);
-      if (nd.isComputed()) trapwriter.addTuple("isComputed", propkey);
+      if (nd.isComputed()) trapwriter.addTuple("is_computed", propkey);
       if (nd.isMethod()) trapwriter.addTuple("isMethod", propkey);
       return propkey;
     }

javascript/extractor/tests/es2015/output/trap/destructuring.js.trap

@@ -784,7 +784,7 @@ enclosing_stmt(#20258,#20249)
 expr_containers(#20258,#20230)
 literals("w","w",#20258)
 decl(#20258,#20234)
-isComputed(#20255)
+is_computed(#20255)
 #20259=*
 exprs(#20259,79,#20251,1,"z")
 hasLocation(#20259,#20162)

javascript/extractor/tests/es2015/output/trap/nullMethodName.js.trap

@@ -163,7 +163,7 @@ locations_default(#20052,#10000,2,17,2,19)
 hasLocation(#20051,#20052)
 stmt_containers(#20051,#20045)
 isMethod(#20042)
-isComputed(#20042)
+is_computed(#20042)
 #20053=*
 properties(#20053,#20038,3,0,"constructor() {}")
 #20054=@"loc,{#10000},1,9,1,8"

javascript/extractor/tests/es2015/output/trap/properties.js.trap

@@ -327,7 +327,7 @@ hasLocation(#20107,#20051)
 enclosing_stmt(#20107,#20083)
 expr_containers(#20107,#20001)
 literals("23","23",#20107)
-isComputed(#20093)
+is_computed(#20093)
 #20108=*
 properties(#20108,#20091,1,0,"x")
 hasLocation(#20108,#20055)

javascript/extractor/tests/es2018/output/trap/asyncIter.js.trap

@@ -490,7 +490,7 @@ locations_default(#20168,#10000,5,35,5,36)
 hasLocation(#20167,#20168)
 stmt_containers(#20167,#20163)
 isMethod(#20156)
-isComputed(#20156)
+is_computed(#20156)
 #20169=*
 properties(#20169,#20143,4,0,"constructor() {}")
 #20170=@"loc,{#10000},3,9,3,8"
@@ -627,7 +627,7 @@ stmts(#20202,1,#20198,-2,"{}")
 locations_default(#20203,#10000,10,35,10,36)
 hasLocation(#20202,#20203)
 stmt_containers(#20202,#20198)
-isComputed(#20192)
+is_computed(#20192)
 isMethod(#20192)
 #20204=*
 entry_cfg_node(#20204,#20001)

javascript/ql/src/semmle/javascript/Aliases.qll

@@ -140,3 +140,8 @@ deprecated predicate isDelegating(YieldExpr yield) { is_delegating(yield) }
  * Use the `ArgumentsVariable` class instead.
  */ 
 deprecated predicate isArgumentsObject(Variable id) { is_arguments_object(id) }
+/**
+ * Alias for the predicate `is_computed` defined in the .dbscheme.
+ * Use the `isComputed()` method on the `MemberDeclaration`/`Property`/`PropertyPattern` class instead.
+ */ 
+deprecated predicate isComputed(Property prop) { is_computed(prop) }

javascript/ql/src/semmle/javascript/Classes.qll

@@ -525,7 +525,7 @@ class MemberDeclaration extends @property, Documentable {
   }
 
   /** Holds if the name of this member is computed. */
-  predicate isComputed() { isComputed(this) }
+  predicate isComputed() { is_computed(this) }
 
   /** Gets the class or interface this member belongs to. */
   ClassOrInterface getDeclaringType() { properties(this, result, _, _, _) }

javascript/ql/src/semmle/javascript/Expr.qll

@@ -614,7 +614,7 @@ class Property extends @property, Documentable {
   }
 
   /** Holds if the name of this property is computed. */
-  predicate isComputed() { isComputed(this) }
+  predicate isComputed() { is_computed(this) }
 
   /** Holds if this property is defined using method syntax. */
   predicate isMethod() { isMethod(this) }

javascript/ql/src/semmle/javascript/Variables.qll

@@ -580,7 +580,7 @@ class PropertyPattern extends @property, ASTNode {
   }
 
   /** Holds if the name of this property pattern is computed. */
-  predicate isComputed() { isComputed(this) }
+  predicate isComputed() { is_computed(this) }
 
   /** Gets the expression specifying the name of the matched property. */
   Expr getNameExpr() { result = this.getChildExpr(0) }

javascript/ql/src/semmlecode.javascript.dbscheme

@@ -513,7 +513,7 @@ case @property.kind of
 @field = @proper_field | @parameter_field;
 @field_or_vardeclarator = @field | @vardeclarator;
 
-isComputed (int id: @property ref);
+is_computed (int id: @property ref);
 isMethod   (int id: @property ref);
 isStatic   (int id: @property ref);
 isAbstractMember (int id: @property ref);

javascript/ql/src/semmlecode.javascript.dbscheme.stats

@@ -13517,7 +13517,7 @@
 </dependencies>
 </relation>
 <relation>
-<name>isComputed</name>
+<name>is_computed</name>
 <cardinality>27</cardinality>
 <columnsizes>
 <e>

javascript/upgrades/c73fbfca57f3d593b9ff50c6aa3a886d6888efec/upgrade.properties

@@ -30,3 +30,5 @@ is_delegating.rel: reorder isDelegating.rel(int yield) yield
 isDelegating.rel: delete
 is_arguments_object.rel: reorder isArgumentsObject.rel(int id) id
 isArgumentsObject.rel: delete
+is_computed.rel: reorder isComputed.rel(int prop) prop
+isComputed.rel: delete