hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 13:15:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
This commit is contained in:
Tony Torralba
2022-01-20 13:44:10 +01:00
committed by GitHub
parent 6096080156
commit 62f847a82e
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/lib/semmle/code/java/frameworks/android/OnActivityResultSource.qll
View File

@@ -46,7 +46,7 @@ class OnActivityResultIncomingIntent extends DataFlow::Node {
.getDeclaringType()
.hasQualifiedName(["android.app", "android.support.v4.app", "androidx.fragment.app"],
"FragmentTransaction") and
any(Argument arg | arg = ma.getAnArgument()).getType() = startingType
ma.getAnArgument().getType() = startingType
or
ma.getMethod().hasName("show") and
ma.getMethod()

2
java/ql/test/library-tests/frameworks/android/sources/OnActivityResultSourceTest.ql
View File

@@ -3,7 +3,7 @@ import semmle.code.java.dataflow.FlowSources
import TestUtilities.InlineFlowTest
class SourceValueFlowConf extends DefaultValueFlowConf {
override predicate isSource(DataFlow::Node sink) { sink instanceof RemoteFlowSource }
override predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
}
class SourceInlineFlowTest extends InlineFlowTest {