Release preparation for version 2.21.2

This commit is contained in:
github-actions[bot]
2025-04-28 10:55:22 +00:00
parent 35939ec3b1
commit 625354c46e
162 changed files with 410 additions and 126 deletions

View File

@@ -1,3 +1,7 @@
## 0.4.8
No user-facing changes.
## 0.4.7 ## 0.4.7
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 0.4.8
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 0.4.7 lastReleaseVersion: 0.4.8

View File

@@ -1,5 +1,5 @@
name: codeql/actions-all name: codeql/actions-all
version: 0.4.8-dev version: 0.4.8
library: true library: true
warnOnImplicitThis: true warnOnImplicitThis: true
dependencies: dependencies:

View File

@@ -1,3 +1,23 @@
## 0.6.0
### Breaking Changes
* The following queries have been removed from the `security-and-quality` suite.
They are not intended to produce user-facing
alerts describing vulnerabilities.
Any existing alerts for these queries will be closed automatically.
* `actions/composite-action-sinks`
* `actions/composite-action-sources`
* `actions/composite-action-summaries`
* `actions/reusable-workflow-sinks`
(renamed from `actions/reusable-wokflow-sinks`)
* `actions/reusable-workflow-sources`
* `actions/reusable-workflow-summaries`
### Bug Fixes
* Assigned a `security-severity` to the query `actions/excessive-secrets-exposure`.
## 0.5.4 ## 0.5.4
### Bug Fixes ### Bug Fixes

View File

@@ -1,4 +0,0 @@
---
category: fix
---
* Assigned a `security-severity` to the query `actions/excessive-secrets-exposure`.

View File

@@ -1,6 +1,6 @@
--- ## 0.6.0
category: breaking
--- ### Breaking Changes
* The following queries have been removed from the `security-and-quality` suite. * The following queries have been removed from the `security-and-quality` suite.
They are not intended to produce user-facing They are not intended to produce user-facing
@@ -13,4 +13,7 @@ category: breaking
(renamed from `actions/reusable-wokflow-sinks`) (renamed from `actions/reusable-wokflow-sinks`)
* `actions/reusable-workflow-sources` * `actions/reusable-workflow-sources`
* `actions/reusable-workflow-summaries` * `actions/reusable-workflow-summaries`
### Bug Fixes
* Assigned a `security-severity` to the query `actions/excessive-secrets-exposure`.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 0.5.4 lastReleaseVersion: 0.6.0

View File

@@ -1,5 +1,5 @@
name: codeql/actions-queries name: codeql/actions-queries
version: 0.5.5-dev version: 0.6.0
library: false library: false
warnOnImplicitThis: true warnOnImplicitThis: true
groups: [actions, queries] groups: [actions, queries]

View File

@@ -1,3 +1,12 @@
## 4.3.0
### New Features
* New classes `TypeofType`, `TypeofExprType`, and `TypeofTypeType` were introduced, which represent the C23 `typeof` and `typeof_unqual` operators. The `TypeofExprType` class represents the variant taking an expression as its argument. The `TypeofTypeType` class represents the variant taking a type as its argument.
* A new class `IntrinsicTransformedType` was introduced, which represents the type transforming intrinsics supported by clang, gcc, and MSVC.
* Introduced `hasDesignator()` predicates to distinguish between designated and positional initializations for both struct/union fields and array elements.
* Added the `isVla()` predicate to the `ArrayType` class. This allows queries to identify variable-length arrays (VLAs).
## 4.2.0 ## 4.2.0
### New Features ### New Features

View File

@@ -1,4 +0,0 @@
---
category: feature
---
* Added the `isVla()` predicate to the `ArrayType` class. This allows queries to identify variable-length arrays (VLAs).

View File

@@ -1,4 +0,0 @@
---
category: feature
---
* Introduced `hasDesignator()` predicates to distinguish between designated and positional initializations for both struct/union fields and array elements.

View File

@@ -1,5 +1,8 @@
--- ## 4.3.0
category: feature
--- ### New Features
* New classes `TypeofType`, `TypeofExprType`, and `TypeofTypeType` were introduced, which represent the C23 `typeof` and `typeof_unqual` operators. The `TypeofExprType` class represents the variant taking an expression as its argument. The `TypeofTypeType` class represents the variant taking a type as its argument. * New classes `TypeofType`, `TypeofExprType`, and `TypeofTypeType` were introduced, which represent the C23 `typeof` and `typeof_unqual` operators. The `TypeofExprType` class represents the variant taking an expression as its argument. The `TypeofTypeType` class represents the variant taking a type as its argument.
* A new class `IntrinsicTransformedType` was introduced, which represents the type transforming intrinsics supported by clang, gcc, and MSVC. * A new class `IntrinsicTransformedType` was introduced, which represents the type transforming intrinsics supported by clang, gcc, and MSVC.
* Introduced `hasDesignator()` predicates to distinguish between designated and positional initializations for both struct/union fields and array elements.
* Added the `isVla()` predicate to the `ArrayType` class. This allows queries to identify variable-length arrays (VLAs).

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 4.2.0 lastReleaseVersion: 4.3.0

View File

@@ -1,5 +1,5 @@
name: codeql/cpp-all name: codeql/cpp-all
version: 4.2.1-dev version: 4.3.0
groups: cpp groups: cpp
dbscheme: semmlecode.cpp.dbscheme dbscheme: semmlecode.cpp.dbscheme
extractor: cpp extractor: cpp

View File

@@ -1,3 +1,7 @@
## 1.3.9
No user-facing changes.
## 1.3.8 ## 1.3.8
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 1.3.9
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.3.8 lastReleaseVersion: 1.3.9

View File

@@ -1,5 +1,5 @@
name: codeql/cpp-queries name: codeql/cpp-queries
version: 1.3.9-dev version: 1.3.9
groups: groups:
- cpp - cpp
- queries - queries

View File

@@ -1,3 +1,7 @@
## 1.7.39
No user-facing changes.
## 1.7.38 ## 1.7.38
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 1.7.39
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.7.38 lastReleaseVersion: 1.7.39

View File

@@ -1,5 +1,5 @@
name: codeql/csharp-solorigate-all name: codeql/csharp-solorigate-all
version: 1.7.39-dev version: 1.7.39
groups: groups:
- csharp - csharp
- solorigate - solorigate

View File

@@ -1,3 +1,7 @@
## 1.7.39
No user-facing changes.
## 1.7.38 ## 1.7.38
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 1.7.39
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.7.38 lastReleaseVersion: 1.7.39

View File

@@ -1,5 +1,5 @@
name: codeql/csharp-solorigate-queries name: codeql/csharp-solorigate-queries
version: 1.7.39-dev version: 1.7.39
groups: groups:
- csharp - csharp
- solorigate - solorigate

View File

@@ -1,3 +1,9 @@
## 5.1.5
### Minor Analysis Improvements
* Improved autobuilder logic for detecting whether a project references a SDK (and should be built using `dotnet`).
## 5.1.4 ## 5.1.4
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -1,4 +1,5 @@
--- ## 5.1.5
category: minorAnalysis
--- ### Minor Analysis Improvements
* Improved autobuilder logic for detecting whether a project references a SDK (and should be built using `dotnet`). * Improved autobuilder logic for detecting whether a project references a SDK (and should be built using `dotnet`).

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 5.1.4 lastReleaseVersion: 5.1.5

View File

@@ -1,5 +1,5 @@
name: codeql/csharp-all name: codeql/csharp-all
version: 5.1.5-dev version: 5.1.5
groups: csharp groups: csharp
dbscheme: semmlecode.csharp.dbscheme dbscheme: semmlecode.csharp.dbscheme
extractor: csharp extractor: csharp

View File

@@ -1,3 +1,11 @@
## 1.1.2
### Minor Analysis Improvements
* Changes to the MaD model generation infrastructure: Changed the query `cs/utils/modelgenerator/summary-models` to use the implementation from `cs/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `cs/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `cs/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).
* Improved detection of authorization checks in the `cs/web/missing-function-level-access-control` query. The query now recognizes authorization attributes inherited from base classes and interfaces.
* The precision of the query `cs/invalid-string-formatting` has been improved. More methods and more overloads of existing format like methods are taken into account by the query.
## 1.1.1 ## 1.1.1
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -1,4 +0,0 @@
---
category: minorAnalysis
---
* The precision of the query `cs/invalid-string-formatting` has been improved. More methods and more overloads of existing format like methods are taken into account by the query.

View File

@@ -1,4 +0,0 @@
---
category: minorAnalysis
---
* Improved detection of authorization checks in the `cs/web/missing-function-level-access-control` query. The query now recognizes authorization attributes inherited from base classes and interfaces.

View File

@@ -1,4 +1,7 @@
--- ## 1.1.2
category: minorAnalysis
--- ### Minor Analysis Improvements
* Changes to the MaD model generation infrastructure: Changed the query `cs/utils/modelgenerator/summary-models` to use the implementation from `cs/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `cs/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `cs/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`). * Changes to the MaD model generation infrastructure: Changed the query `cs/utils/modelgenerator/summary-models` to use the implementation from `cs/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `cs/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `cs/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).
* Improved detection of authorization checks in the `cs/web/missing-function-level-access-control` query. The query now recognizes authorization attributes inherited from base classes and interfaces.
* The precision of the query `cs/invalid-string-formatting` has been improved. More methods and more overloads of existing format like methods are taken into account by the query.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.1.1 lastReleaseVersion: 1.1.2

View File

@@ -1,5 +1,5 @@
name: codeql/csharp-queries name: codeql/csharp-queries
version: 1.1.2-dev version: 1.1.2
groups: groups:
- csharp - csharp
- queries - queries

View File

@@ -1,3 +1,7 @@
## 1.0.22
No user-facing changes.
## 1.0.21 ## 1.0.21
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 1.0.22
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.0.21 lastReleaseVersion: 1.0.22

View File

@@ -1,5 +1,5 @@
name: codeql-go-consistency-queries name: codeql-go-consistency-queries
version: 1.0.22-dev version: 1.0.22
groups: groups:
- go - go
- queries - queries

View File

@@ -1,3 +1,7 @@
## 4.2.4
No user-facing changes.
## 4.2.3 ## 4.2.3
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 4.2.4
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 4.2.3 lastReleaseVersion: 4.2.4

View File

@@ -1,5 +1,5 @@
name: codeql/go-all name: codeql/go-all
version: 4.2.4-dev version: 4.2.4
groups: go groups: go
dbscheme: go.dbscheme dbscheme: go.dbscheme
extractor: go extractor: go

View File

@@ -1,3 +1,7 @@
## 1.1.13
No user-facing changes.
## 1.1.12 ## 1.1.12
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 1.1.13
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.1.12 lastReleaseVersion: 1.1.13

View File

@@ -1,5 +1,5 @@
name: codeql/go-queries name: codeql/go-queries
version: 1.1.13-dev version: 1.1.13
groups: groups:
- go - go
- queries - queries

View File

@@ -1,3 +1,7 @@
## 7.1.4
No user-facing changes.
## 7.1.3 ## 7.1.3
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 7.1.4
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 7.1.3 lastReleaseVersion: 7.1.4

View File

@@ -1,5 +1,5 @@
name: codeql/java-all name: codeql/java-all
version: 7.1.4-dev version: 7.1.4
groups: java groups: java
dbscheme: config/semmlecode.dbscheme dbscheme: config/semmlecode.dbscheme
extractor: java extractor: java

View File

@@ -1,3 +1,9 @@
## 1.4.2
### Minor Analysis Improvements
* Changes to the MaD model generation infrastructure: Changed the query `java/utils/modelgenerator/summary-models` to use the implementation from `java/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `java/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `java/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).
## 1.4.1 ## 1.4.1
No user-facing changes. No user-facing changes.

View File

@@ -1,4 +1,5 @@
--- ## 1.4.2
category: minorAnalysis
--- ### Minor Analysis Improvements
* Changes to the MaD model generation infrastructure: Changed the query `java/utils/modelgenerator/summary-models` to use the implementation from `java/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `java/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `java/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).
* Changes to the MaD model generation infrastructure: Changed the query `java/utils/modelgenerator/summary-models` to use the implementation from `java/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `java/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `java/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.4.1 lastReleaseVersion: 1.4.2

View File

@@ -1,5 +1,5 @@
name: codeql/java-queries name: codeql/java-queries
version: 1.4.2-dev version: 1.4.2
groups: groups:
- java - java
- queries - queries

View File

@@ -1,3 +1,7 @@
## 2.6.2
No user-facing changes.
## 2.6.1 ## 2.6.1
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 2.6.2
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 2.6.1 lastReleaseVersion: 2.6.2

View File

@@ -1,5 +1,5 @@
name: codeql/javascript-all name: codeql/javascript-all
version: 2.6.2-dev version: 2.6.2
groups: javascript groups: javascript
dbscheme: semmlecode.javascript.dbscheme dbscheme: semmlecode.javascript.dbscheme
extractor: javascript extractor: javascript

View File

@@ -1,3 +1,7 @@
## 1.5.4
No user-facing changes.
## 1.5.3 ## 1.5.3
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 1.5.4
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.5.3 lastReleaseVersion: 1.5.4

View File

@@ -1,5 +1,5 @@
name: codeql/javascript-queries name: codeql/javascript-queries
version: 1.5.4-dev version: 1.5.4
groups: groups:
- javascript - javascript
- queries - queries

View File

@@ -1,3 +1,7 @@
## 1.0.22
No user-facing changes.
## 1.0.21 ## 1.0.21
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 1.0.22
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.0.21 lastReleaseVersion: 1.0.22

View File

@@ -1,4 +1,4 @@
name: codeql/suite-helpers name: codeql/suite-helpers
version: 1.0.22-dev version: 1.0.22
groups: shared groups: shared
warnOnImplicitThis: true warnOnImplicitThis: true

View File

@@ -1,3 +1,7 @@
## 4.0.6
No user-facing changes.
## 4.0.5 ## 4.0.5
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 4.0.6
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 4.0.5 lastReleaseVersion: 4.0.6

View File

@@ -1,5 +1,5 @@
name: codeql/python-all name: codeql/python-all
version: 4.0.6-dev version: 4.0.6
groups: python groups: python
dbscheme: semmlecode.python.dbscheme dbscheme: semmlecode.python.dbscheme
extractor: python extractor: python

View File

@@ -1,3 +1,7 @@
## 1.4.8
No user-facing changes.
## 1.4.7 ## 1.4.7
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 1.4.8
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.4.7 lastReleaseVersion: 1.4.8

View File

@@ -1,5 +1,5 @@
name: codeql/python-queries name: codeql/python-queries
version: 1.4.8-dev version: 1.4.8
groups: groups:
- python - python
- queries - queries

View File

@@ -1,3 +1,7 @@
## 4.1.5
No user-facing changes.
## 4.1.4 ## 4.1.4
### Minor Analysis Improvements ### Minor Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 4.1.5
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 4.1.4 lastReleaseVersion: 4.1.5

View File

@@ -1,5 +1,5 @@
name: codeql/ruby-all name: codeql/ruby-all
version: 4.1.5-dev version: 4.1.5
groups: ruby groups: ruby
extractor: ruby extractor: ruby
dbscheme: ruby.dbscheme dbscheme: ruby.dbscheme

View File

@@ -1,3 +1,7 @@
## 1.2.1
No user-facing changes.
## 1.2.0 ## 1.2.0
### Major Analysis Improvements ### Major Analysis Improvements

View File

@@ -0,0 +1,3 @@
## 1.2.1
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 1.2.0 lastReleaseVersion: 1.2.1

View File

@@ -1,5 +1,5 @@
name: codeql/ruby-queries name: codeql/ruby-queries
version: 1.2.1-dev version: 1.2.1
groups: groups:
- ruby - ruby
- queries - queries

View File

@@ -1,3 +1,7 @@
## 0.1.7
No user-facing changes.
## 0.1.6 ## 0.1.6
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 0.1.7
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 0.1.6 lastReleaseVersion: 0.1.7

View File

@@ -1,5 +1,5 @@
name: codeql/rust-all name: codeql/rust-all
version: 0.1.7-dev version: 0.1.7
groups: rust groups: rust
extractor: rust extractor: rust
dbscheme: rust.dbscheme dbscheme: rust.dbscheme

View File

@@ -1,3 +1,9 @@
## 0.1.7
### Minor Analysis Improvements
* Changes to the MaD model generation infrastructure: Changed the query `rust/utils/modelgenerator/summary-models` to use the implementation from `rust/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `rust/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `rust/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).
## 0.1.6 ## 0.1.6
No user-facing changes. No user-facing changes.

View File

@@ -1,4 +1,5 @@
--- ## 0.1.7
category: minorAnalysis
--- ### Minor Analysis Improvements
* Changes to the MaD model generation infrastructure: Changed the query `rust/utils/modelgenerator/summary-models` to use the implementation from `rust/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `rust/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `rust/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).
* Changes to the MaD model generation infrastructure: Changed the query `rust/utils/modelgenerator/summary-models` to use the implementation from `rust/utils/modelgenerator/mixed-summary-models`. Removed the now-redundant `rust/utils/modelgenerator/mixed-summary-models` query. Similar replacement was made for `rust/utils/modelgenerator/neutral-models`. That is, if `GenerateFlowModel.py` is provided with `--with-summaries` combined/mixed models are now generated instead of heuristic models (and similar for `--with-neutrals`).

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 0.1.6 lastReleaseVersion: 0.1.7

View File

@@ -1,5 +1,5 @@
name: codeql/rust-queries name: codeql/rust-queries
version: 0.1.7-dev version: 0.1.7
groups: groups:
- rust - rust
- queries - queries

View File

@@ -1,3 +1,7 @@
## 2.0.6
No user-facing changes.
## 2.0.5 ## 2.0.5
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 2.0.6
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 2.0.5 lastReleaseVersion: 2.0.6

View File

@@ -1,5 +1,5 @@
name: codeql/controlflow name: codeql/controlflow
version: 2.0.6-dev version: 2.0.6
groups: shared groups: shared
library: true library: true
dependencies: dependencies:

View File

@@ -1,3 +1,7 @@
## 2.0.6
No user-facing changes.
## 2.0.5 ## 2.0.5
No user-facing changes. No user-facing changes.

View File

@@ -0,0 +1,3 @@
## 2.0.6
No user-facing changes.

View File

@@ -1,2 +1,2 @@
--- ---
lastReleaseVersion: 2.0.5 lastReleaseVersion: 2.0.6

Some files were not shown because too many files have changed in this diff Show More